Use more secure methods#3291
Merged
Merged
Conversation
ashie
approved these changes
Mar 12, 2021
|
|
||
| param = if val.is_a?(String) | ||
| val.start_with?('{') ? JSON.load(val) : Hash[val.strip.split(/\s*,\s*/).map{|v| v.split(':', 2)}] | ||
| val.start_with?('{') ? JSON.parse(val) : Hash[val.strip.split(/\s*,\s*/).map{|v| v.split(':', 2)}] |
Member
There was a problem hiding this comment.
Memo:
JSON.load wraps JSON.parse and it modifies some default options of JSON::Parser:
https://github.com/flori/json/blob/7b452b290502a5cca8fc6403f31275c83e0e3d48/lib/json/common.rb#L569
https://github.com/flori/json/blob/7b452b290502a5cca8fc6403f31275c83e0e3d48/lib/json/common.rb#L422
https://docs.ruby-lang.org/ja/latest/class/JSON=3a=3aParser.html
So that the behavior is also changed a bit but I believe it's no problem on this case.
Contributor
Author
There was a problem hiding this comment.
Thanks for the clarification. Yeah, in this case, using JSON.parse instead of JSON.load does not cause issues.
kenhys
reviewed
Mar 12, 2021
kenhys
left a comment
Contributor
There was a problem hiding this comment.
Could you add a reference to why it should be fixed in the commit message?
Then LGTM.
27ed7dd to
a6af121
Compare
Contributor
|
I doubt whether https://deepsource.io/gh/cosmo0920/fluentd/issue/RB-SC1002 is consistent or not. How about quoting the following: |
* https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Security/Open ``` `Kernel#open` and `URI.open` enable not only file access but also process invocation by prefixing a pipe symbol (e.g., `open(“| ls”)`). So, it may lead to a serious security risk by using variable input to the argument of `Kernel#open` and `URI.open`. It would be better to use `File.open`, `IO.popen` or `URI.parse#open` explicitly. ``` Signed-off-by: Hiroshi Hatake <hatake@clear-code.com>
* https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Security/JSONLoad ``` Autocorrect is disabled by default because it's potentially dangerous. If using a stream, like `JSON.load(open('file'))`, it will need to call `#read` manually, like `JSON.parse(open('file').read)`. If reading single values (rather than proper JSON objects), like `JSON.load('false')`, it will need to pass the `quirks_mode: true` option, like `JSON.parse('false', quirks_mode: true)`. Other similar issues may apply. ``` Signed-off-by: Hiroshi Hatake <hatake@clear-code.com>
a6af121 to
77d79e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
None
What this PR does / why we need it:
DeepSource complains that fluentd uses insecure methods:
Kernel.open: https://deepsource.io/gh/cosmo0920/fluentd/issue/RB-SC1004/JSON.load: https://deepsource.io/gh/cosmo0920/fluentd/issue/RB-SC1002/occurrencesDocs Changes:
No need.
Release Note:
Same as title.