GitHub Actions: Add macOS and remove .travis.yml#3290
Merged
Conversation
Signed-off-by: Takuro Ashie <ashie@clear-code.com>
We've completely moved to GitHub Actions. CI for Some minor platforms has been dropped. * ppc64le * s390x Signed-off-by: Takuro Ashie <ashie@clear-code.com>
Fix the following failure:
Failure: test: can execute external command just once, and can terminate it forcedly when shutdown/terminate even if it ignore SIGTERM(ChildProcessTest):
assert { lines2 > lines1 }
| | |
| | 0
| false
0
/Users/runner/work/fluentd/fluentd/test/plugin_helper/test_child_process.rb:301:in `block (2 levels) in <class:ChildProcessTest>'
298: @d.shutdown
299: sleep TEST_WAIT_INTERVAL_FOR_LOOP
300: lines2 = ary.size
=> 301: assert { lines2 > lines1 }
302: @d.close
303:
304: assert_nil((Process.waitpid(pid, Process::WNOHANG) rescue nil))
Signed-off-by: Takuro Ashie <ashie@clear-code.com>
Signed-off-by: Takuro Ashie <ashie@clear-code.com>
cosmo0920
approved these changes
Mar 10, 2021
cosmo0920
left a comment
Contributor
There was a problem hiding this comment.
I'd confirmed that always failing testcase on macOS should be fixed. 💪
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
none
What this PR does / why we need it:
We are migrating CI from TravisCI to GitHub Actions.
This PR add macOS workflow on GitHub Actions and remove .travis.yml to complete this work.
Other minor platforms are dropped by this PR because GitHub Actions doesn't support them:
Docs Changes:
none
Release Note:
none