Tweak GitHub Actions and Remove AppVeyor#3281
Merged
Merged
Conversation
Signed-off-by: Takuro Ashie <ashie@clear-code.com>
Signed-off-by: Takuro Ashie <ashie@clear-code.com>
Signed-off-by: Takuro Ashie <ashie@clear-code.com>
Signed-off-by: Takuro Ashie <ashie@clear-code.com>
Detailed information for succeeded tests shouldn't be shown to highlight failed tests. Signed-off-by: Takuro Ashie <ashie@clear-code.com>
It doesn't support kwargs of Ruby 3 yet. https://github.com/rr/rr/blob/223378ae65175a22aeb5254d7719a56d02f0ba76/lib/rr/injections/double_injection.rb#L149 Above code should pass not only *args but also **kwargs to an original method. Signed-off-by: Takuro Ashie <ashie@clear-code.com>
Signed-off-by: Takuro Ashie <ashie@clear-code.com>
Signed-off-by: Takuro Ashie <ashie@clear-code.com>
It seems that GitHub Actions is enough instead, it's much faster than AppVeyor because max number of parallel workers is lager than it. Although dozens of in_tail tests are still failed, it's same with AppVeyor. Signed-off-by: Takuro Ashie <ashie@clear-code.com>
cosmo0920
approved these changes
Mar 5, 2021
cosmo0920
left a comment
Contributor
There was a problem hiding this comment.
LGTM.
Yeah, key words arguments failures on Ruby 3.0 should be fixed later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
none
What this PR does / why we need it:
We need to tune CI because recently it always fail.
This PR is an intermediate result of tuning it:
Docs Changes:
none
Release Note:
none