test: avoid conflict access to tempfile on windows#3268
Merged
Conversation
It is straight forward enough to use File.stat for these test cases. Signed-off-by: Kentaro Hayashi <kenhys@gmail.com>
Contributor
Author
|
On windows, it will pass. |
Contributor
|
I'd confirmed that this patch makes green on position testcases on Windows. |
cosmo0920
approved these changes
Mar 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
N/A
What this PR does / why we need it:
It is a straight forward enough approach to use File.stat for these
test cases.
In test case, setup creates a temporary file and each test case try to access
via Fluent::Filewrapper.stat but it causes INVALID_HANDLE_VALUE.
Docs Changes:
N/A
Release Note:
N/A