Skip to content

Make better use of freeze#3170

Merged
repeatedly merged 1 commit into
masterfrom
better-freeze
Nov 16, 2020
Merged

Make better use of freeze#3170
repeatedly merged 1 commit into
masterfrom
better-freeze

Conversation

@repeatedly

Copy link
Copy Markdown
Member

Signed-off-by: Masahiro Nakagawa repeatedly@gmail.com

Which issue(s) this PR fixes:
Follow up: #3152

What this PR does / why we need it:

  • Add freeze to string parameter
  • Remove duplicated freeze

Docs Changes:
No need

Release Note:
Add this to Refactoring code

Signed-off-by: Masahiro Nakagawa <repeatedly@gmail.com>
@repeatedly repeatedly added the enhancement Feature request or improve operations label Nov 16, 2020
@repeatedly repeatedly requested a review from cosmo0920 November 16, 2020 06:51
@repeatedly repeatedly self-assigned this Nov 16, 2020

@cosmo0920 cosmo0920 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. 👍

@repeatedly repeatedly merged commit 5e036cf into master Nov 16, 2020
@repeatedly repeatedly deleted the better-freeze branch November 16, 2020 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Feature request or improve operations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants