Skip to content

Refactor buffer code#3118

Merged
repeatedly merged 3 commits into
masterfrom
refactor-buffer-code
Sep 1, 2020
Merged

Refactor buffer code#3118
repeatedly merged 3 commits into
masterfrom
refactor-buffer-code

Conversation

@repeatedly

Copy link
Copy Markdown
Member

Which issue(s) this PR fixes:
Follow up: #3018

What this PR does / why we need it:

  • Skip timekeys calculation when no time chunk key. This is for the performance.
  • Improve/refactor buffer code

Docs Changes:
No need

Release Note:
Listed in Refactoring code section.

Signed-off-by: Masahiro Nakagawa <repeatedly@gmail.com>
Signed-off-by: Masahiro Nakagawa <repeatedly@gmail.com>
Signed-off-by: Masahiro Nakagawa <repeatedly@gmail.com>
@repeatedly repeatedly added the enhancement Feature request or improve operations label Aug 31, 2020
@repeatedly repeatedly requested a review from cosmo0920 August 31, 2020 11:13
@repeatedly repeatedly self-assigned this Aug 31, 2020

@cosmo0920 cosmo0920 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@repeatedly repeatedly merged commit b5f4a6d into master Sep 1, 2020
@cosmo0920 cosmo0920 deleted the refactor-buffer-code branch September 1, 2020 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Feature request or improve operations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants