Wait until @tails is set a new watcher#2896
Merged
Merged
Conversation
`@tails` can be 0 after Driver::Base#run when [this line](https://github.com/fluent/fluentd/blob/2b7ed60ddc7edbab0dcbb57d4a13c4dd5175512d/lib/fluent/test/driver/base.rb#L96 ) is performed between [#setup_watcher](https://github.com/fluent/fluentd/blob/2b7ed60ddc7edbab0dcbb57d4a13c4dd5175512d/lib/fluent/plugin/in_tail.rb#L334) in [#start_watchers](https://github.com/fluent/fluentd/blob/2b7ed60ddc7edbab0dcbb57d4a13c4dd5175512d/lib/fluent/plugin/in_tail.rb#L368) and [setting the value to @Tails](https://github.com/fluent/fluentd/blob/2b7ed60ddc7edbab0dcbb57d4a13c4dd5175512d/lib/fluent/plugin/in_tail.rb#L373) Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
repeatedly
approved these changes
Mar 18, 2020
cosmo0920
approved these changes
Mar 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yuta Iwama ganmacs@gmail.com
Which issue(s) this PR fixes:
fixes https://travis-ci.org/github/fluent/fluentd/jobs/663388229#L761
What this PR does / why we need it:
@tailscan be 0 after Driver::Base#runwhen this line is performed between #setup_watcher in #start_watchers and setting the value to @tails
Docs Changes:
no need
Release Note:
no need