Optimize dirList#435
Merged
Merged
Conversation
climba03003
requested changes
Feb 6, 2024
Co-authored-by: KaKa <23028015+climba03003@users.noreply.github.com> Signed-off-by: Gürgün Dayıoğlu <hey@gurgun.day>
climba03003
approved these changes
Feb 6, 2024
ddadaal
referenced
this pull request
in PKUHPC/OpenSCOW
Feb 18, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@fastify/static](https://togithub.com/fastify/fastify-static) | [`6.12.0` -> `7.0.1`](https://renovatebot.com/diffs/npm/@fastify%2fstatic/6.12.0/7.0.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>fastify/fastify-static (@​fastify/static)</summary> ### [`v7.0.1`](https://togithub.com/fastify/fastify-static/releases/tag/v7.0.1) [Compare Source](https://togithub.com/fastify/fastify-static/compare/v7.0.0...v7.0.1) #### What's Changed - build(deps-dev): bump [@​fastify/compress](https://togithub.com/fastify/compress) from 6.5.0 to 7.0.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/fastify/fastify-static/pull/433](https://togithub.com/fastify/fastify-static/pull/433) - Optimize `dirList` by [@​gurgunday](https://togithub.com/gurgunday) in [https://github.com/fastify/fastify-static/pull/435](https://togithub.com/fastify/fastify-static/pull/435) - fix: file not found errors when the root has a trailing slash by [@​gurgunday](https://togithub.com/gurgunday) in [https://github.com/fastify/fastify-static/pull/436](https://togithub.com/fastify/fastify-static/pull/436) **Full Changelog**: fastify/fastify-static@v7.0.0...v7.0.1 ### [`v7.0.0`](https://togithub.com/fastify/fastify-static/releases/tag/v7.0.0) [Compare Source](https://togithub.com/fastify/fastify-static/compare/v6.12.0...v7.0.0) #### What's Changed - build(deps-dev): bump tsd from 0.29.0 to 0.30.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/fastify/fastify-static/pull/424](https://togithub.com/fastify/fastify-static/pull/424) - docs(readme): replace `fastify.io` links with `fastify.dev` by [@​Fdawgs](https://togithub.com/Fdawgs) in [https://github.com/fastify/fastify-static/pull/425](https://togithub.com/fastify/fastify-static/pull/425) - docs(readme): replace `fastify.io` links with `fastify.dev` by [@​Fdawgs](https://togithub.com/Fdawgs) in [https://github.com/fastify/fastify-static/pull/426](https://togithub.com/fastify/fastify-static/pull/426) - chore(package): fix repository url by [@​Fdawgs](https://togithub.com/Fdawgs) in [https://github.com/fastify/fastify-static/pull/429](https://togithub.com/fastify/fastify-static/pull/429) - chore: improve types for `setHeaders` option by [@​EvanHahn](https://togithub.com/EvanHahn) in [https://github.com/fastify/fastify-static/pull/428](https://togithub.com/fastify/fastify-static/pull/428) - Upgrade glob to v10 by [@​gurgunday](https://togithub.com/gurgunday) in [https://github.com/fastify/fastify-static/pull/406](https://togithub.com/fastify/fastify-static/pull/406) #### New Contributors - [@​EvanHahn](https://togithub.com/EvanHahn) made their first contribution in [https://github.com/fastify/fastify-static/pull/428](https://togithub.com/fastify/fastify-static/pull/428) **Full Changelog**: fastify/fastify-static@v6.12.0...v7.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on sunday" in timezone Asia/Shanghai, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/PKUHPC/SCOW). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNTMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjE3My4wIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dirListmethods are potentially called on each request to a resourceIt had a high number of inline functions that are independent of their scope, which might make it difficult for V8 to optimize them
This PR simply extracts those functions so that they're created once and can be better optimized; it also switches to
fastqby @mcollina fromp-limit