Upgrade glob to v10#406
Conversation
|
Damn it actually worked 🤣 This should merge after #405 |
|
Not sure about the license check that failed, one package seems to be using the |
|
We may add it to the workflow: |
@Eomm how can we do that? |
|
Seems to be a hornet nest :( https://writing.kemitchell.com/2019/05/05/Rely-on-OSI.html |
This reverts commit 32f875d.
|
Looks like a cool license 🤠 |
mcollina
left a comment
There was a problem hiding this comment.
This is one thing I'll put a temporary -1 on. I would need to check with the OpenJS Lawyers about this.
According to the OpenJS IP policy we cannot use BlueOak-1.0.0 https://openjsf.org/wp-content/uploads/sites/84/2019/10/OpenJS-Foundation-IP-Policy-2019-10-22.pdf.
|
Oh, I didn't know that, no problem! |
This reverts commit aad0548.
Wait, what? Why isn't BlueOak acceptable? |
|
It's not OSI approved (by design). Trying to get a new OSS license through a major company legal department is very hard and that rule account for that. Note that we have the license checker since before we went into openjs exactly for this reason. |
|
We had some adoption issue due to light-my-request BSD license (as funny as it sounds). |
|
@mcollina is BSD-2-Clause-Patent acceptable in your opinion? |
|
I know about the workflow, I'm just asking if, according to OpenJS Foundation policy, I'd say no, but just wanted to make sure, to maybe switch some personal packages to it if that's not the case |
|
what library is using that license? |
|
None that I know of I asked because I was considering creating a faster glob implementation that is as correct as |
|
This can merge now |
|
@gurgunday Can you please add blue oak to the workflows? |
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@fastify/static](https://togithub.com/fastify/fastify-static) | [`6.12.0` -> `7.0.1`](https://renovatebot.com/diffs/npm/@fastify%2fstatic/6.12.0/7.0.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>fastify/fastify-static (@​fastify/static)</summary> ### [`v7.0.1`](https://togithub.com/fastify/fastify-static/releases/tag/v7.0.1) [Compare Source](https://togithub.com/fastify/fastify-static/compare/v7.0.0...v7.0.1) #### What's Changed - build(deps-dev): bump [@​fastify/compress](https://togithub.com/fastify/compress) from 6.5.0 to 7.0.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/fastify/fastify-static/pull/433](https://togithub.com/fastify/fastify-static/pull/433) - Optimize `dirList` by [@​gurgunday](https://togithub.com/gurgunday) in [https://github.com/fastify/fastify-static/pull/435](https://togithub.com/fastify/fastify-static/pull/435) - fix: file not found errors when the root has a trailing slash by [@​gurgunday](https://togithub.com/gurgunday) in [https://github.com/fastify/fastify-static/pull/436](https://togithub.com/fastify/fastify-static/pull/436) **Full Changelog**: fastify/fastify-static@v7.0.0...v7.0.1 ### [`v7.0.0`](https://togithub.com/fastify/fastify-static/releases/tag/v7.0.0) [Compare Source](https://togithub.com/fastify/fastify-static/compare/v6.12.0...v7.0.0) #### What's Changed - build(deps-dev): bump tsd from 0.29.0 to 0.30.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/fastify/fastify-static/pull/424](https://togithub.com/fastify/fastify-static/pull/424) - docs(readme): replace `fastify.io` links with `fastify.dev` by [@​Fdawgs](https://togithub.com/Fdawgs) in [https://github.com/fastify/fastify-static/pull/425](https://togithub.com/fastify/fastify-static/pull/425) - docs(readme): replace `fastify.io` links with `fastify.dev` by [@​Fdawgs](https://togithub.com/Fdawgs) in [https://github.com/fastify/fastify-static/pull/426](https://togithub.com/fastify/fastify-static/pull/426) - chore(package): fix repository url by [@​Fdawgs](https://togithub.com/Fdawgs) in [https://github.com/fastify/fastify-static/pull/429](https://togithub.com/fastify/fastify-static/pull/429) - chore: improve types for `setHeaders` option by [@​EvanHahn](https://togithub.com/EvanHahn) in [https://github.com/fastify/fastify-static/pull/428](https://togithub.com/fastify/fastify-static/pull/428) - Upgrade glob to v10 by [@​gurgunday](https://togithub.com/gurgunday) in [https://github.com/fastify/fastify-static/pull/406](https://togithub.com/fastify/fastify-static/pull/406) #### New Contributors - [@​EvanHahn](https://togithub.com/EvanHahn) made their first contribution in [https://github.com/fastify/fastify-static/pull/428](https://togithub.com/fastify/fastify-static/pull/428) **Full Changelog**: fastify/fastify-static@v6.12.0...v7.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on sunday" in timezone Asia/Shanghai, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/PKUHPC/SCOW). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNTMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjE3My4wIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
What changed: glob is stricter in its syntax so we have to escape characters more consistently
Closes: #402
Checklist
npm run testandnpm run benchmarkand the Code of conduct