fix: HEAD route reseting by ivan-tymoshenko · Pull Request #5090 · fastify/fastify

ivan-tymoshenko · 2023-10-11T22:31:42Z

climba03003 · 2023-10-12T03:38:14Z

      // remove the head route created by fastify
      if (hasHEADHandler && !context[kRouteByFastify] && headHandler.store[kRouteByFastify]) {
-        router.off('HEAD', opts.url, { constraints })
+        router.off('HEAD', opts.url, constraints)


~~Why .on and .off is not using the same syntax?~~
Double checked on find-my-way, it is actually not the same.

climba03003 · 2023-10-12T03:40:04Z

Some test need to be adjusted.

ivan-tymoshenko · 2023-10-12T08:24:26Z

Some test need to be adjusted.

What tests?

ivan-tymoshenko · 2023-10-12T08:57:16Z

Can't tell now, but having that this tests shouldn't fail, it looks like another bug in fastify.

ivan-tymoshenko · 2023-10-12T10:25:32Z

I didn't expect it to be broken on so many levels.

mcollina

lgtm

climba03003

The logic looks fine.

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [fastify](https://www.fastify.dev/) ([source](https://togithub.com/fastify/fastify)) | [`4.24.0` -> `4.24.1`](https://renovatebot.com/diffs/npm/fastify/4.24.0/4.24.1) | [![age](https://developer.mend.io/api/mc/badges/age/npm/fastify/4.24.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/fastify/4.24.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/fastify/4.24.0/4.24.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/fastify/4.24.0/4.24.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>fastify/fastify (fastify)</summary> ### [`v4.24.1`](https://togithub.com/fastify/fastify/releases/tag/v4.24.1) [Compare Source](https://togithub.com/fastify/fastify/compare/v4.24.0...v4.24.1) #### What's Changed - fix: citgm by [@simone-sanfratello](https://togithub.com/simone-sanfratello) in [https://github.com/fastify/fastify/pull/5075](https://togithub.com/fastify/fastify/pull/5075) - fix: HEAD route reseting by [@ivan-tymoshenko](https://togithub.com/ivan-tymoshenko) in [https://github.com/fastify/fastify/pull/5090](https://togithub.com/fastify/fastify/pull/5090) **Full Changelog**: fastify/fastify@v4.24.0...v4.24.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/tomacheese/telcheck).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

github-actions · 2024-10-14T00:28:41Z

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

fix: HEAD route reseting

51c2807

climba03003 requested changes Oct 12, 2023

View reviewed changes

This comment was marked as outdated.

Sign in to view

fix: HEAD route reseting

9629965

mcollina approved these changes Oct 12, 2023

View reviewed changes

ivan-tymoshenko marked this pull request as draft October 12, 2023 10:29

fix: HEAD route reseting

d30c875

ivan-tymoshenko marked this pull request as ready for review October 12, 2023 10:32

climba03003 approved these changes Oct 12, 2023

View reviewed changes

mcollina merged commit 91c7b44 into fastify:main Oct 12, 2023

renovate Bot mentioned this pull request Oct 29, 2023

chore(deps): update all non-major dependencies cyco130/vavite#74

Merged

1 task

github-actions Bot locked as resolved and limited conversation to collaborators Oct 14, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: HEAD route reseting#5090

fix: HEAD route reseting#5090
mcollina merged 3 commits into
fastify:mainfrom
ivan-tymoshenko:fix-head-route-reseting

ivan-tymoshenko commented Oct 11, 2023

Uh oh!

climba03003 Oct 12, 2023 •

edited

Loading

Uh oh!

climba03003 commented Oct 12, 2023

Uh oh!

ivan-tymoshenko commented Oct 12, 2023

Uh oh!

This comment was marked as outdated.

ivan-tymoshenko commented Oct 12, 2023 •

edited

Loading

Uh oh!

ivan-tymoshenko commented Oct 12, 2023

Uh oh!

mcollina left a comment

Uh oh!

climba03003 left a comment

Uh oh!

github-actions Bot commented Oct 14, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

ivan-tymoshenko commented Oct 11, 2023

Uh oh!

climba03003 Oct 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

climba03003 commented Oct 12, 2023

Uh oh!

ivan-tymoshenko commented Oct 12, 2023

Uh oh!

This comment was marked as outdated.

ivan-tymoshenko commented Oct 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ivan-tymoshenko commented Oct 12, 2023

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

climba03003 left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Oct 14, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

climba03003 Oct 12, 2023 •

edited

Loading

ivan-tymoshenko commented Oct 12, 2023 •

edited

Loading