fix: citgm#5075
Merged
Merged
Conversation
0af6029 to
93b2034
Compare
7bf73a0 to
0621717
Compare
8d051ef to
c199882
Compare
Member
|
We have citgm passing now with this PR. |
renovate Bot
referenced
this pull request
in tomacheese/telcheck
Oct 13, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [fastify](https://www.fastify.dev/) ([source](https://togithub.com/fastify/fastify)) | [`4.24.0` -> `4.24.1`](https://renovatebot.com/diffs/npm/fastify/4.24.0/4.24.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>fastify/fastify (fastify)</summary> ### [`v4.24.1`](https://togithub.com/fastify/fastify/releases/tag/v4.24.1) [Compare Source](https://togithub.com/fastify/fastify/compare/v4.24.0...v4.24.1) #### What's Changed - fix: citgm by [@​simone-sanfratello](https://togithub.com/simone-sanfratello) in [https://github.com/fastify/fastify/pull/5075](https://togithub.com/fastify/fastify/pull/5075) - fix: HEAD route reseting by [@​ivan-tymoshenko](https://togithub.com/ivan-tymoshenko) in [https://github.com/fastify/fastify/pull/5090](https://togithub.com/fastify/fastify/pull/5090) **Full Changelog**: fastify/fastify@v4.24.0...v4.24.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/tomacheese/telcheck). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44LjEiLCJ1cGRhdGVkSW5WZXIiOiIzNy44LjEiLCJ0YXJnZXRCcmFuY2giOiJtYXN0ZXIifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
jtoar
referenced
this pull request
in redwoodjs/graphql
Nov 15, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [fastify](https://www.fastify.dev/) ([source](https://togithub.com/fastify/fastify)) | [`4.23.2` -> `4.24.3`](https://renovatebot.com/diffs/npm/fastify/4.23.2/4.24.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>fastify/fastify (fastify)</summary> ### [`v4.24.3`](https://togithub.com/fastify/fastify/releases/tag/v4.24.3) [Compare Source](https://togithub.com/fastify/fastify/compare/v4.24.2...v4.24.3) #### What's Changed - fix: timeout on citgm tests by [@​simone-sanfratello](https://togithub.com/simone-sanfratello) in [https://github.com/fastify/fastify/pull/5101](https://togithub.com/fastify/fastify/pull/5101) - chore: add missing `use strict` directives by [@​Fdawgs](https://togithub.com/Fdawgs) in [https://github.com/fastify/fastify/pull/5106](https://togithub.com/fastify/fastify/pull/5106) **Full Changelog**: fastify/fastify@v4.24.2...v4.24.3 ### [`v4.24.2`](https://togithub.com/fastify/fastify/releases/tag/v4.24.2) [Compare Source](https://togithub.com/fastify/fastify/compare/v4.24.1...v4.24.2) #### What's Changed - fix: build problems when `Symbol.asyncDispose` type is not available. by [@​arthurfiorette](https://togithub.com/arthurfiorette) in [https://github.com/fastify/fastify/pull/5096](https://togithub.com/fastify/fastify/pull/5096) **Full Changelog**: fastify/fastify@v4.24.1...v4.24.2 ### [`v4.24.1`](https://togithub.com/fastify/fastify/releases/tag/v4.24.1) [Compare Source](https://togithub.com/fastify/fastify/compare/v4.24.0...v4.24.1) #### What's Changed - fix: citgm by [@​simone-sanfratello](https://togithub.com/simone-sanfratello) in [https://github.com/fastify/fastify/pull/5075](https://togithub.com/fastify/fastify/pull/5075) - fix: HEAD route reseting by [@​ivan-tymoshenko](https://togithub.com/ivan-tymoshenko) in [https://github.com/fastify/fastify/pull/5090](https://togithub.com/fastify/fastify/pull/5090) **Full Changelog**: fastify/fastify@v4.24.0...v4.24.1 ### [`v4.24.0`](https://togithub.com/fastify/fastify/releases/tag/v4.24.0) [Compare Source](https://togithub.com/fastify/fastify/compare/v4.23.2...v4.24.0) #### What's Changed - docs: Add blank line before onclose hook heading by [@​kadoshita](https://togithub.com/kadoshita) in [https://github.com/fastify/fastify/pull/5042](https://togithub.com/fastify/fastify/pull/5042) - build(dependabot): ignore tap major updates by [@​Fdawgs](https://togithub.com/Fdawgs) in [https://github.com/fastify/fastify/pull/5047](https://togithub.com/fastify/fastify/pull/5047) - chore: Bump actions/checkout from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/fastify/fastify/pull/5048](https://togithub.com/fastify/fastify/pull/5048) - chore: more perf by [@​Eomm](https://togithub.com/Eomm) in [https://github.com/fastify/fastify/pull/5016](https://togithub.com/fastify/fastify/pull/5016) - docs(ecosystem): add fastify-prisma by [@​zrosenbauer](https://togithub.com/zrosenbauer) in [https://github.com/fastify/fastify/pull/5041](https://togithub.com/fastify/fastify/pull/5041) - test: fix ci due yup breaking by [@​Eomm](https://togithub.com/Eomm) in [https://github.com/fastify/fastify/pull/5058](https://togithub.com/fastify/fastify/pull/5058) - perf: optimize split params by [@​Connormiha](https://togithub.com/Connormiha) in [https://github.com/fastify/fastify/pull/5057](https://togithub.com/fastify/fastify/pull/5057) - chore: implicitly infer SchemaCompiler as readonly by [@​DemonHa](https://togithub.com/DemonHa) in [https://github.com/fastify/fastify/pull/5060](https://togithub.com/fastify/fastify/pull/5060) - test(logger): splitting existing tests to avoid pipeline failing for timeout by [@​giuliowaitforitdavide](https://togithub.com/giuliowaitforitdavide) in [https://github.com/fastify/fastify/pull/5064](https://togithub.com/fastify/fastify/pull/5064) - fix(async-hooks): mixing async and callback style in preHandler option now returns an error by [@​giuliowaitforitdavide](https://togithub.com/giuliowaitforitdavide) in [https://github.com/fastify/fastify/pull/5069](https://togithub.com/fastify/fastify/pull/5069) - fix: enhance 100 and 200 or 204 handling by [@​Iamshankhadeep](https://togithub.com/Iamshankhadeep) in [https://github.com/fastify/fastify/pull/5056](https://togithub.com/fastify/fastify/pull/5056) - docs: add fastify-cloudflare-turnstile to ecosystem by [@​112RG](https://togithub.com/112RG) in [https://github.com/fastify/fastify/pull/5067](https://togithub.com/fastify/fastify/pull/5067) - docs: Fixing a couple typos by [@​Cadienvan](https://togithub.com/Cadienvan) in [https://github.com/fastify/fastify/pull/5079](https://togithub.com/fastify/fastify/pull/5079) - feat: Add `Symbol.asyncDispose` to improve DX in short lived servers. by [@​arthurfiorette](https://togithub.com/arthurfiorette) in [https://github.com/fastify/fastify/pull/5082](https://togithub.com/fastify/fastify/pull/5082) - docs: Documentation changes requested at [#​5082](https://togithub.com/fastify/fastify/issues/5082) by [@​arthurfiorette](https://togithub.com/arthurfiorette) in [https://github.com/fastify/fastify/pull/5083](https://togithub.com/fastify/fastify/pull/5083) - docs: remove thenable promisesaplus spec references by [@​dancastillo](https://togithub.com/dancastillo) in [https://github.com/fastify/fastify/pull/5081](https://togithub.com/fastify/fastify/pull/5081) - docs(ecosystem): add fastify-event-bus by [@​Shiva127](https://togithub.com/Shiva127) in [https://github.com/fastify/fastify/pull/5085](https://togithub.com/fastify/fastify/pull/5085) - docs: update docs for FastifyPlugin by [@​dancastillo](https://togithub.com/dancastillo) in [https://github.com/fastify/fastify/pull/5070](https://togithub.com/fastify/fastify/pull/5070) - docs: Update for .hijack heading by [@​jackbatzner](https://togithub.com/jackbatzner) in [https://github.com/fastify/fastify/pull/5088](https://togithub.com/fastify/fastify/pull/5088) - fix(warnings): fixed warning when accessing context property from Request and Reply objects by [@​giuliowaitforitdavide](https://togithub.com/giuliowaitforitdavide) in [https://github.com/fastify/fastify/pull/5084](https://togithub.com/fastify/fastify/pull/5084) - fix: HEAD route search by [@​ivan-tymoshenko](https://togithub.com/ivan-tymoshenko) in [https://github.com/fastify/fastify/pull/5078](https://togithub.com/fastify/fastify/pull/5078) #### New Contributors - [@​kadoshita](https://togithub.com/kadoshita) made their first contribution in [https://github.com/fastify/fastify/pull/5042](https://togithub.com/fastify/fastify/pull/5042) - [@​Connormiha](https://togithub.com/Connormiha) made their first contribution in [https://github.com/fastify/fastify/pull/5057](https://togithub.com/fastify/fastify/pull/5057) - [@​DemonHa](https://togithub.com/DemonHa) made their first contribution in [https://github.com/fastify/fastify/pull/5060](https://togithub.com/fastify/fastify/pull/5060) - [@​Iamshankhadeep](https://togithub.com/Iamshankhadeep) made their first contribution in [https://github.com/fastify/fastify/pull/5056](https://togithub.com/fastify/fastify/pull/5056) - [@​Cadienvan](https://togithub.com/Cadienvan) made their first contribution in [https://github.com/fastify/fastify/pull/5079](https://togithub.com/fastify/fastify/pull/5079) - [@​arthurfiorette](https://togithub.com/arthurfiorette) made their first contribution in [https://github.com/fastify/fastify/pull/5082](https://togithub.com/fastify/fastify/pull/5082) - [@​jackbatzner](https://togithub.com/jackbatzner) made their first contribution in [https://github.com/fastify/fastify/pull/5088](https://togithub.com/fastify/fastify/pull/5088) **Full Changelog**: fastify/fastify@v4.23.2...v4.24.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/redwoodjs/redwood). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40Ni4wIiwidXBkYXRlZEluVmVyIjoiMzcuNDYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
jtoar
referenced
this pull request
in redwoodjs/graphql
Nov 16, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [fastify](https://www.fastify.dev/) ([source](https://togithub.com/fastify/fastify)) | [`4.23.2` -> `4.24.3`](https://renovatebot.com/diffs/npm/fastify/4.23.2/4.24.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- <details> <summary>fastify/fastify (fastify)</summary> [`v4.24.3`](https://togithub.com/fastify/fastify/releases/tag/v4.24.3) [Compare Source](https://togithub.com/fastify/fastify/compare/v4.24.2...v4.24.3) - fix: timeout on citgm tests by [@​simone-sanfratello](https://togithub.com/simone-sanfratello) in [https://github.com/fastify/fastify/pull/5101](https://togithub.com/fastify/fastify/pull/5101) - chore: add missing `use strict` directives by [@​Fdawgs](https://togithub.com/Fdawgs) in [https://github.com/fastify/fastify/pull/5106](https://togithub.com/fastify/fastify/pull/5106) **Full Changelog**: fastify/fastify@v4.24.2...v4.24.3 [`v4.24.2`](https://togithub.com/fastify/fastify/releases/tag/v4.24.2) [Compare Source](https://togithub.com/fastify/fastify/compare/v4.24.1...v4.24.2) - fix: build problems when `Symbol.asyncDispose` type is not available. by [@​arthurfiorette](https://togithub.com/arthurfiorette) in [https://github.com/fastify/fastify/pull/5096](https://togithub.com/fastify/fastify/pull/5096) **Full Changelog**: fastify/fastify@v4.24.1...v4.24.2 [`v4.24.1`](https://togithub.com/fastify/fastify/releases/tag/v4.24.1) [Compare Source](https://togithub.com/fastify/fastify/compare/v4.24.0...v4.24.1) - fix: citgm by [@​simone-sanfratello](https://togithub.com/simone-sanfratello) in [https://github.com/fastify/fastify/pull/5075](https://togithub.com/fastify/fastify/pull/5075) - fix: HEAD route reseting by [@​ivan-tymoshenko](https://togithub.com/ivan-tymoshenko) in [https://github.com/fastify/fastify/pull/5090](https://togithub.com/fastify/fastify/pull/5090) **Full Changelog**: fastify/fastify@v4.24.0...v4.24.1 [`v4.24.0`](https://togithub.com/fastify/fastify/releases/tag/v4.24.0) [Compare Source](https://togithub.com/fastify/fastify/compare/v4.23.2...v4.24.0) - docs: Add blank line before onclose hook heading by [@​kadoshita](https://togithub.com/kadoshita) in [https://github.com/fastify/fastify/pull/5042](https://togithub.com/fastify/fastify/pull/5042) - build(dependabot): ignore tap major updates by [@​Fdawgs](https://togithub.com/Fdawgs) in [https://github.com/fastify/fastify/pull/5047](https://togithub.com/fastify/fastify/pull/5047) - chore: Bump actions/checkout from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/fastify/fastify/pull/5048](https://togithub.com/fastify/fastify/pull/5048) - chore: more perf by [@​Eomm](https://togithub.com/Eomm) in [https://github.com/fastify/fastify/pull/5016](https://togithub.com/fastify/fastify/pull/5016) - docs(ecosystem): add fastify-prisma by [@​zrosenbauer](https://togithub.com/zrosenbauer) in [https://github.com/fastify/fastify/pull/5041](https://togithub.com/fastify/fastify/pull/5041) - test: fix ci due yup breaking by [@​Eomm](https://togithub.com/Eomm) in [https://github.com/fastify/fastify/pull/5058](https://togithub.com/fastify/fastify/pull/5058) - perf: optimize split params by [@​Connormiha](https://togithub.com/Connormiha) in [https://github.com/fastify/fastify/pull/5057](https://togithub.com/fastify/fastify/pull/5057) - chore: implicitly infer SchemaCompiler as readonly by [@​DemonHa](https://togithub.com/DemonHa) in [https://github.com/fastify/fastify/pull/5060](https://togithub.com/fastify/fastify/pull/5060) - test(logger): splitting existing tests to avoid pipeline failing for timeout by [@​giuliowaitforitdavide](https://togithub.com/giuliowaitforitdavide) in [https://github.com/fastify/fastify/pull/5064](https://togithub.com/fastify/fastify/pull/5064) - fix(async-hooks): mixing async and callback style in preHandler option now returns an error by [@​giuliowaitforitdavide](https://togithub.com/giuliowaitforitdavide) in [https://github.com/fastify/fastify/pull/5069](https://togithub.com/fastify/fastify/pull/5069) - fix: enhance 100 and 200 or 204 handling by [@​Iamshankhadeep](https://togithub.com/Iamshankhadeep) in [https://github.com/fastify/fastify/pull/5056](https://togithub.com/fastify/fastify/pull/5056) - docs: add fastify-cloudflare-turnstile to ecosystem by [@​112RG](https://togithub.com/112RG) in [https://github.com/fastify/fastify/pull/5067](https://togithub.com/fastify/fastify/pull/5067) - docs: Fixing a couple typos by [@​Cadienvan](https://togithub.com/Cadienvan) in [https://github.com/fastify/fastify/pull/5079](https://togithub.com/fastify/fastify/pull/5079) - feat: Add `Symbol.asyncDispose` to improve DX in short lived servers. by [@​arthurfiorette](https://togithub.com/arthurfiorette) in [https://github.com/fastify/fastify/pull/5082](https://togithub.com/fastify/fastify/pull/5082) - docs: Documentation changes requested at [#​5082](https://togithub.com/fastify/fastify/issues/5082) by [@​arthurfiorette](https://togithub.com/arthurfiorette) in [https://github.com/fastify/fastify/pull/5083](https://togithub.com/fastify/fastify/pull/5083) - docs: remove thenable promisesaplus spec references by [@​dancastillo](https://togithub.com/dancastillo) in [https://github.com/fastify/fastify/pull/5081](https://togithub.com/fastify/fastify/pull/5081) - docs(ecosystem): add fastify-event-bus by [@​Shiva127](https://togithub.com/Shiva127) in [https://github.com/fastify/fastify/pull/5085](https://togithub.com/fastify/fastify/pull/5085) - docs: update docs for FastifyPlugin by [@​dancastillo](https://togithub.com/dancastillo) in [https://github.com/fastify/fastify/pull/5070](https://togithub.com/fastify/fastify/pull/5070) - docs: Update for .hijack heading by [@​jackbatzner](https://togithub.com/jackbatzner) in [https://github.com/fastify/fastify/pull/5088](https://togithub.com/fastify/fastify/pull/5088) - fix(warnings): fixed warning when accessing context property from Request and Reply objects by [@​giuliowaitforitdavide](https://togithub.com/giuliowaitforitdavide) in [https://github.com/fastify/fastify/pull/5084](https://togithub.com/fastify/fastify/pull/5084) - fix: HEAD route search by [@​ivan-tymoshenko](https://togithub.com/ivan-tymoshenko) in [https://github.com/fastify/fastify/pull/5078](https://togithub.com/fastify/fastify/pull/5078) - [@​kadoshita](https://togithub.com/kadoshita) made their first contribution in [https://github.com/fastify/fastify/pull/5042](https://togithub.com/fastify/fastify/pull/5042) - [@​Connormiha](https://togithub.com/Connormiha) made their first contribution in [https://github.com/fastify/fastify/pull/5057](https://togithub.com/fastify/fastify/pull/5057) - [@​DemonHa](https://togithub.com/DemonHa) made their first contribution in [https://github.com/fastify/fastify/pull/5060](https://togithub.com/fastify/fastify/pull/5060) - [@​Iamshankhadeep](https://togithub.com/Iamshankhadeep) made their first contribution in [https://github.com/fastify/fastify/pull/5056](https://togithub.com/fastify/fastify/pull/5056) - [@​Cadienvan](https://togithub.com/Cadienvan) made their first contribution in [https://github.com/fastify/fastify/pull/5079](https://togithub.com/fastify/fastify/pull/5079) - [@​arthurfiorette](https://togithub.com/arthurfiorette) made their first contribution in [https://github.com/fastify/fastify/pull/5082](https://togithub.com/fastify/fastify/pull/5082) - [@​jackbatzner](https://togithub.com/jackbatzner) made their first contribution in [https://github.com/fastify/fastify/pull/5088](https://togithub.com/fastify/fastify/pull/5088) **Full Changelog**: fastify/fastify@v4.23.2...v4.24.0 </details> --- 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/redwoodjs/redwood). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40Ni4wIiwidXBkYXRlZEluVmVyIjoiMzcuNDYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
jsumners
reviewed
Oct 23, 2024
Comment on lines
-3
to
+4
| const selfCert = require('self-cert') | ||
| const os = require('os') | ||
| const forge = require('node-forge') |
Member
There was a problem hiding this comment.
I missed this and am now seeing it in #5757. Why did we embed this code? @simone-sanfratello @mcollina
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following nodejs/citgm#973
Tested locally on node 21 nightly
test files:
custom-parser.1.test.jslisten.test.jsplugin.test.jsroute.test.jsstream.test.jsHave been splitted because they contained too many tests, that hit timeout on slow citgm machines
Note before merge:
console.logsnpm testas it wascitgmscript is been used on citgm, must be inlookup.jsonfile or citgm settingsNote to future me: run it as
citgm git+https://github.com/simone-sanfratello/fastify#fix/citgm -l lookup.jsonlookup.json
{ "useGitClone": true, "scripts": ["citgm"] }