Skip to content

chore: more perf#5016

Merged
Uzlopak merged 8 commits into
mainfrom
perf-small
Sep 19, 2023
Merged

chore: more perf#5016
Uzlopak merged 8 commits into
mainfrom
perf-small

Conversation

@Eomm

@Eomm Eomm commented Sep 3, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

It gives me +1k req/sec avg on my PC

@Eomm Eomm added performances Everything related to performances chore Small changes or internal project maintenance benchmark Label to run benchmark against PR and main branch labels Sep 3, 2023
@github-actions

github-actions Bot commented Sep 3, 2023

Copy link
Copy Markdown

Node: 16
PR: [1] 1705k requests in 30.07s, 320 MB read
MAIN: [1] 1717k requests in 30.06s, 323 MB read

Node: 18
PR: [1] 1253k requests in 30.06s, 235 MB read
MAIN: [1] 1294k requests in 30.05s, 243 MB read

Node: 20
PR: [1] 612k requests in 30.11s, 115 MB read
MAIN: [1] 637k requests in 30.13s, 120 MB read

@github-actions github-actions Bot removed the benchmark Label to run benchmark against PR and main branch label Sep 3, 2023
Uzlopak
Uzlopak reviewed Sep 3, 2023
View reviewed changes
Comment thread lib/reply.js Outdated
Uzlopak
Uzlopak reviewed Sep 3, 2023
View reviewed changes
Comment thread lib/request.js

function buildRegularRequest (R) {
const props = [...R.props]
const props = R.props.slice()

@Uzlopak Uzlopak Sep 3, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wasnt there something that says that spread is faster than slice?

@Eomm Eomm Sep 3, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That array contains decorators, so it is empty most of the times or it does not have too much stuff:

object:

slice x 66,902,400 ops/sec ±0.98% (90 runs sampled)
spread x 46,305,568 ops/sec ±1.00% (94 runs sampled)
Fastest is slice

empty array:

slice x 175,975,861 ops/sec ±1.07% (83 runs sampled)
spread x 104,123,703 ops/sec ±1.07% (96 runs sampled)
Fastest is slice
Click to expand! 
'use strict'
const Benchmark = require('benchmark')

const suite = new Benchmark.Suite()

const array = []
// const array = new Array(10).fill({ key: 'value', value: () => { } })

suite.add('slice', function () {
  return array.slice()
})

suite.add('spread', function () {
  return [...array]
})

// add listeners
suite.on('cycle', function (event) {
  console.log(String(event.target))
})
  .on('complete', function () {
    console.log('Fastest is ' + this.filter('fastest').map('name'))
  })
  // run async
  .run()

Eomm and others added 2 commits September 3, 2023 14:22
@Eomm
chore: perf syntax reply
18c87bc
@Eomm @Uzlopak
chore: Update lib/reply.js
fbcce7c 
Co-authored-by: Uzlopak <aras.abbasi@googlemail.com>
@Eomm Eomm added the benchmark Label to run benchmark against PR and main branch label Sep 3, 2023
@github-actions

github-actions Bot commented Sep 3, 2023

Copy link
Copy Markdown

Node: 16
PR: [1] 1751k requests in 30.15s, 329 MB read
MAIN: [1] 1846k requests in 30.12s, 347 MB read

Node: 18
PR: [1] 1655k requests in 30.05s, 311 MB read
MAIN: [1] 1680k requests in 30.04s, 316 MB read

Node: 20
PR: [1] 1683k requests in 30.04s, 316 MB read
MAIN: [1] 1701k requests in 30.04s, 320 MB read

@github-actions github-actions Bot removed the benchmark Label to run benchmark against PR and main branch label Sep 3, 2023
@Eomm Eomm added the benchmark Label to run benchmark against PR and main branch label Sep 3, 2023
@github-actions

github-actions Bot commented Sep 3, 2023

Copy link
Copy Markdown

Node: 16
PR: [1] 1826k requests in 30.05s, 343 MB read
MAIN: [1] 1848k requests in 30.07s, 347 MB read

Node: 18
PR: [1] 1645k requests in 30.05s, 309 MB read
MAIN: [1] 1656k requests in 30.05s, 311 MB read

Node: 20
PR: [1] 1507k requests in 30.09s, 283 MB read
MAIN: [1] 1495k requests in 30.05s, 281 MB read

@github-actions github-actions Bot removed the benchmark Label to run benchmark against PR and main branch label Sep 3, 2023
@Eomm Eomm added the benchmark Label to run benchmark against PR and main branch label Sep 3, 2023
@github-actions

github-actions Bot commented Sep 3, 2023

Copy link
Copy Markdown

Node: 16
PR: [1] 1702k requests in 30.07s, 320 MB read
MAIN: [1] 1701k requests in 30.06s, 320 MB read

Node: 18
PR: [1] 1637k requests in 30.04s, 308 MB read
MAIN: [1] 1624k requests in 30.06s, 305 MB read

Node: 20
PR: [1] 1663k requests in 30.06s, 313 MB read
MAIN: [1] 1697k requests in 30.05s, 319 MB read

@github-actions github-actions Bot removed the benchmark Label to run benchmark against PR and main branch label Sep 3, 2023
@Eomm

Eomm commented Sep 3, 2023

Copy link
Copy Markdown
Member Author

Only Node 20 is constantly faster

Node: 20
PR: [1] 1663k requests in 30.06s, 313 MB read
MAIN: [1] 1697k requests in 30.05s, 319 MB read

@gurgunday

gurgunday commented Sep 3, 2023

Copy link
Copy Markdown
Member

Only Node 20 is constantly faster

In any case these changes look great, especially having less iterators

@mcollina

mcollina commented Sep 3, 2023

Copy link
Copy Markdown
Member

I'll check it on my dedicated server

metcoder95
metcoder95 reviewed Sep 4, 2023
View reviewed changes
Comment thread lib/reply.js
rozzilla
rozzilla approved these changes Sep 17, 2023
View reviewed changes

@rozzilla rozzilla left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super Interesting!

mcollina
mcollina approved these changes Sep 18, 2023
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Eomm Eomm requested a review from Uzlopak September 19, 2023 05:20
Uzlopak
Uzlopak approved these changes Sep 19, 2023
View reviewed changes

@Uzlopak Uzlopak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Uzlopak Uzlopak merged commit ffcffb2 into main Sep 19, 2023
@Uzlopak Uzlopak deleted the perf-small branch September 19, 2023 07:57
renovate Bot referenced this pull request in tomacheese/telcheck Oct 11, 2023
@renovate
chore(deps): update dependency fastify to v4.24.0 (#321)
ae070a3 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [fastify](https://www.fastify.dev/)
([source](https://togithub.com/fastify/fastify)) | [`4.23.2` ->
`4.24.0`](https://renovatebot.com/diffs/npm/fastify/4.23.2/4.24.0) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/fastify/4.24.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/fastify/4.24.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/fastify/4.23.2/4.24.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/fastify/4.23.2/4.24.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>fastify/fastify (fastify)</summary>

###
[`v4.24.0`](https://togithub.com/fastify/fastify/releases/tag/v4.24.0)

[Compare
Source](https://togithub.com/fastify/fastify/compare/v4.23.2...v4.24.0)

#### What's Changed

- docs: Add blank line before onclose hook heading by
[@&#8203;kadoshita](https://togithub.com/kadoshita) in
[https://github.com/fastify/fastify/pull/5042](https://togithub.com/fastify/fastify/pull/5042)
- build(dependabot): ignore tap major updates by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[https://github.com/fastify/fastify/pull/5047](https://togithub.com/fastify/fastify/pull/5047)
- chore: Bump actions/checkout from 3 to 4 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/fastify/fastify/pull/5048](https://togithub.com/fastify/fastify/pull/5048)
- chore: more perf by [@&#8203;Eomm](https://togithub.com/Eomm) in
[https://github.com/fastify/fastify/pull/5016](https://togithub.com/fastify/fastify/pull/5016)
- docs(ecosystem): add fastify-prisma by
[@&#8203;zrosenbauer](https://togithub.com/zrosenbauer) in
[https://github.com/fastify/fastify/pull/5041](https://togithub.com/fastify/fastify/pull/5041)
- test: fix ci due yup breaking by
[@&#8203;Eomm](https://togithub.com/Eomm) in
[https://github.com/fastify/fastify/pull/5058](https://togithub.com/fastify/fastify/pull/5058)
- perf: optimize split params by
[@&#8203;Connormiha](https://togithub.com/Connormiha) in
[https://github.com/fastify/fastify/pull/5057](https://togithub.com/fastify/fastify/pull/5057)
- chore: implicitly infer SchemaCompiler as readonly by
[@&#8203;DemonHa](https://togithub.com/DemonHa) in
[https://github.com/fastify/fastify/pull/5060](https://togithub.com/fastify/fastify/pull/5060)
- test(logger): splitting existing tests to avoid pipeline failing for
timeout by
[@&#8203;giuliowaitforitdavide](https://togithub.com/giuliowaitforitdavide)
in
[https://github.com/fastify/fastify/pull/5064](https://togithub.com/fastify/fastify/pull/5064)
- fix(async-hooks): mixing async and callback style in preHandler option
now returns an error by
[@&#8203;giuliowaitforitdavide](https://togithub.com/giuliowaitforitdavide)
in
[https://github.com/fastify/fastify/pull/5069](https://togithub.com/fastify/fastify/pull/5069)
- fix: enhance 100 and 200 or 204 handling by
[@&#8203;Iamshankhadeep](https://togithub.com/Iamshankhadeep) in
[https://github.com/fastify/fastify/pull/5056](https://togithub.com/fastify/fastify/pull/5056)
- docs: add fastify-cloudflare-turnstile to ecosystem by
[@&#8203;112RG](https://togithub.com/112RG) in
[https://github.com/fastify/fastify/pull/5067](https://togithub.com/fastify/fastify/pull/5067)
- docs: Fixing a couple typos by
[@&#8203;Cadienvan](https://togithub.com/Cadienvan) in
[https://github.com/fastify/fastify/pull/5079](https://togithub.com/fastify/fastify/pull/5079)
- feat: Add `Symbol.asyncDispose` to improve DX in short lived servers.
by [@&#8203;arthurfiorette](https://togithub.com/arthurfiorette) in
[https://github.com/fastify/fastify/pull/5082](https://togithub.com/fastify/fastify/pull/5082)
- docs: Documentation changes requested at
[#&#8203;5082](https://togithub.com/fastify/fastify/issues/5082) by
[@&#8203;arthurfiorette](https://togithub.com/arthurfiorette) in
[https://github.com/fastify/fastify/pull/5083](https://togithub.com/fastify/fastify/pull/5083)
- docs: remove thenable promisesaplus spec references by
[@&#8203;dancastillo](https://togithub.com/dancastillo) in
[https://github.com/fastify/fastify/pull/5081](https://togithub.com/fastify/fastify/pull/5081)
- docs(ecosystem): add fastify-event-bus by
[@&#8203;Shiva127](https://togithub.com/Shiva127) in
[https://github.com/fastify/fastify/pull/5085](https://togithub.com/fastify/fastify/pull/5085)
- docs: update docs for FastifyPlugin by
[@&#8203;dancastillo](https://togithub.com/dancastillo) in
[https://github.com/fastify/fastify/pull/5070](https://togithub.com/fastify/fastify/pull/5070)
- docs: Update for .hijack heading by
[@&#8203;jackbatzner](https://togithub.com/jackbatzner) in
[https://github.com/fastify/fastify/pull/5088](https://togithub.com/fastify/fastify/pull/5088)
- fix(warnings): fixed warning when accessing context property from
Request and Reply objects by
[@&#8203;giuliowaitforitdavide](https://togithub.com/giuliowaitforitdavide)
in
[https://github.com/fastify/fastify/pull/5084](https://togithub.com/fastify/fastify/pull/5084)
- fix: HEAD route search by
[@&#8203;ivan-tymoshenko](https://togithub.com/ivan-tymoshenko) in
[https://github.com/fastify/fastify/pull/5078](https://togithub.com/fastify/fastify/pull/5078)

#### New Contributors

- [@&#8203;kadoshita](https://togithub.com/kadoshita) made their first
contribution in
[https://github.com/fastify/fastify/pull/5042](https://togithub.com/fastify/fastify/pull/5042)
- [@&#8203;Connormiha](https://togithub.com/Connormiha) made their first
contribution in
[https://github.com/fastify/fastify/pull/5057](https://togithub.com/fastify/fastify/pull/5057)
- [@&#8203;DemonHa](https://togithub.com/DemonHa) made their first
contribution in
[https://github.com/fastify/fastify/pull/5060](https://togithub.com/fastify/fastify/pull/5060)
- [@&#8203;Iamshankhadeep](https://togithub.com/Iamshankhadeep) made
their first contribution in
[https://github.com/fastify/fastify/pull/5056](https://togithub.com/fastify/fastify/pull/5056)
- [@&#8203;Cadienvan](https://togithub.com/Cadienvan) made their first
contribution in
[https://github.com/fastify/fastify/pull/5079](https://togithub.com/fastify/fastify/pull/5079)
- [@&#8203;arthurfiorette](https://togithub.com/arthurfiorette) made
their first contribution in
[https://github.com/fastify/fastify/pull/5082](https://togithub.com/fastify/fastify/pull/5082)
- [@&#8203;jackbatzner](https://togithub.com/jackbatzner) made their
first contribution in
[https://github.com/fastify/fastify/pull/5088](https://togithub.com/fastify/fastify/pull/5088)

**Full Changelog**:
fastify/fastify@v4.23.2...v4.24.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/tomacheese/telcheck).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44LjEiLCJ1cGRhdGVkSW5WZXIiOiIzNy44LjEiLCJ0YXJnZXRCcmFuY2giOiJtYXN0ZXIifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
jtoar referenced this pull request in redwoodjs/graphql Nov 15, 2023
@renovate
fix(deps): update dependency fastify to v4.24.3 (#9457)
0510002 
[![Mend Renovate logo
banner](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [fastify](https://www.fastify.dev/)
([source](https://togithub.com/fastify/fastify)) | [`4.23.2` ->
`4.24.3`](https://renovatebot.com/diffs/npm/fastify/4.23.2/4.24.3) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/fastify/4.24.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/fastify/4.24.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/fastify/4.23.2/4.24.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/fastify/4.23.2/4.24.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>fastify/fastify (fastify)</summary>

###
[`v4.24.3`](https://togithub.com/fastify/fastify/releases/tag/v4.24.3)

[Compare
Source](https://togithub.com/fastify/fastify/compare/v4.24.2...v4.24.3)

#### What's Changed

- fix: timeout on citgm tests by
[@&#8203;simone-sanfratello](https://togithub.com/simone-sanfratello) in
[https://github.com/fastify/fastify/pull/5101](https://togithub.com/fastify/fastify/pull/5101)
- chore: add missing `use strict` directives by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[https://github.com/fastify/fastify/pull/5106](https://togithub.com/fastify/fastify/pull/5106)

**Full Changelog**:
fastify/fastify@v4.24.2...v4.24.3

###
[`v4.24.2`](https://togithub.com/fastify/fastify/releases/tag/v4.24.2)

[Compare
Source](https://togithub.com/fastify/fastify/compare/v4.24.1...v4.24.2)

#### What's Changed

- fix: build problems when `Symbol.asyncDispose` type is not available.
by [@&#8203;arthurfiorette](https://togithub.com/arthurfiorette) in
[https://github.com/fastify/fastify/pull/5096](https://togithub.com/fastify/fastify/pull/5096)

**Full Changelog**:
fastify/fastify@v4.24.1...v4.24.2

###
[`v4.24.1`](https://togithub.com/fastify/fastify/releases/tag/v4.24.1)

[Compare
Source](https://togithub.com/fastify/fastify/compare/v4.24.0...v4.24.1)

#### What's Changed

- fix: citgm by
[@&#8203;simone-sanfratello](https://togithub.com/simone-sanfratello) in
[https://github.com/fastify/fastify/pull/5075](https://togithub.com/fastify/fastify/pull/5075)
- fix: HEAD route reseting by
[@&#8203;ivan-tymoshenko](https://togithub.com/ivan-tymoshenko) in
[https://github.com/fastify/fastify/pull/5090](https://togithub.com/fastify/fastify/pull/5090)

**Full Changelog**:
fastify/fastify@v4.24.0...v4.24.1

###
[`v4.24.0`](https://togithub.com/fastify/fastify/releases/tag/v4.24.0)

[Compare
Source](https://togithub.com/fastify/fastify/compare/v4.23.2...v4.24.0)

#### What's Changed

- docs: Add blank line before onclose hook heading by
[@&#8203;kadoshita](https://togithub.com/kadoshita) in
[https://github.com/fastify/fastify/pull/5042](https://togithub.com/fastify/fastify/pull/5042)
- build(dependabot): ignore tap major updates by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[https://github.com/fastify/fastify/pull/5047](https://togithub.com/fastify/fastify/pull/5047)
- chore: Bump actions/checkout from 3 to 4 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/fastify/fastify/pull/5048](https://togithub.com/fastify/fastify/pull/5048)
- chore: more perf by [@&#8203;Eomm](https://togithub.com/Eomm) in
[https://github.com/fastify/fastify/pull/5016](https://togithub.com/fastify/fastify/pull/5016)
- docs(ecosystem): add fastify-prisma by
[@&#8203;zrosenbauer](https://togithub.com/zrosenbauer) in
[https://github.com/fastify/fastify/pull/5041](https://togithub.com/fastify/fastify/pull/5041)
- test: fix ci due yup breaking by
[@&#8203;Eomm](https://togithub.com/Eomm) in
[https://github.com/fastify/fastify/pull/5058](https://togithub.com/fastify/fastify/pull/5058)
- perf: optimize split params by
[@&#8203;Connormiha](https://togithub.com/Connormiha) in
[https://github.com/fastify/fastify/pull/5057](https://togithub.com/fastify/fastify/pull/5057)
- chore: implicitly infer SchemaCompiler as readonly by
[@&#8203;DemonHa](https://togithub.com/DemonHa) in
[https://github.com/fastify/fastify/pull/5060](https://togithub.com/fastify/fastify/pull/5060)
- test(logger): splitting existing tests to avoid pipeline failing for
timeout by
[@&#8203;giuliowaitforitdavide](https://togithub.com/giuliowaitforitdavide)
in
[https://github.com/fastify/fastify/pull/5064](https://togithub.com/fastify/fastify/pull/5064)
- fix(async-hooks): mixing async and callback style in preHandler option
now returns an error by
[@&#8203;giuliowaitforitdavide](https://togithub.com/giuliowaitforitdavide)
in
[https://github.com/fastify/fastify/pull/5069](https://togithub.com/fastify/fastify/pull/5069)
- fix: enhance 100 and 200 or 204 handling by
[@&#8203;Iamshankhadeep](https://togithub.com/Iamshankhadeep) in
[https://github.com/fastify/fastify/pull/5056](https://togithub.com/fastify/fastify/pull/5056)
- docs: add fastify-cloudflare-turnstile to ecosystem by
[@&#8203;112RG](https://togithub.com/112RG) in
[https://github.com/fastify/fastify/pull/5067](https://togithub.com/fastify/fastify/pull/5067)
- docs: Fixing a couple typos by
[@&#8203;Cadienvan](https://togithub.com/Cadienvan) in
[https://github.com/fastify/fastify/pull/5079](https://togithub.com/fastify/fastify/pull/5079)
- feat: Add `Symbol.asyncDispose` to improve DX in short lived servers.
by [@&#8203;arthurfiorette](https://togithub.com/arthurfiorette) in
[https://github.com/fastify/fastify/pull/5082](https://togithub.com/fastify/fastify/pull/5082)
- docs: Documentation changes requested at
[#&#8203;5082](https://togithub.com/fastify/fastify/issues/5082) by
[@&#8203;arthurfiorette](https://togithub.com/arthurfiorette) in
[https://github.com/fastify/fastify/pull/5083](https://togithub.com/fastify/fastify/pull/5083)
- docs: remove thenable promisesaplus spec references by
[@&#8203;dancastillo](https://togithub.com/dancastillo) in
[https://github.com/fastify/fastify/pull/5081](https://togithub.com/fastify/fastify/pull/5081)
- docs(ecosystem): add fastify-event-bus by
[@&#8203;Shiva127](https://togithub.com/Shiva127) in
[https://github.com/fastify/fastify/pull/5085](https://togithub.com/fastify/fastify/pull/5085)
- docs: update docs for FastifyPlugin by
[@&#8203;dancastillo](https://togithub.com/dancastillo) in
[https://github.com/fastify/fastify/pull/5070](https://togithub.com/fastify/fastify/pull/5070)
- docs: Update for .hijack heading by
[@&#8203;jackbatzner](https://togithub.com/jackbatzner) in
[https://github.com/fastify/fastify/pull/5088](https://togithub.com/fastify/fastify/pull/5088)
- fix(warnings): fixed warning when accessing context property from
Request and Reply objects by
[@&#8203;giuliowaitforitdavide](https://togithub.com/giuliowaitforitdavide)
in
[https://github.com/fastify/fastify/pull/5084](https://togithub.com/fastify/fastify/pull/5084)
- fix: HEAD route search by
[@&#8203;ivan-tymoshenko](https://togithub.com/ivan-tymoshenko) in
[https://github.com/fastify/fastify/pull/5078](https://togithub.com/fastify/fastify/pull/5078)

#### New Contributors

- [@&#8203;kadoshita](https://togithub.com/kadoshita) made their first
contribution in
[https://github.com/fastify/fastify/pull/5042](https://togithub.com/fastify/fastify/pull/5042)
- [@&#8203;Connormiha](https://togithub.com/Connormiha) made their first
contribution in
[https://github.com/fastify/fastify/pull/5057](https://togithub.com/fastify/fastify/pull/5057)
- [@&#8203;DemonHa](https://togithub.com/DemonHa) made their first
contribution in
[https://github.com/fastify/fastify/pull/5060](https://togithub.com/fastify/fastify/pull/5060)
- [@&#8203;Iamshankhadeep](https://togithub.com/Iamshankhadeep) made
their first contribution in
[https://github.com/fastify/fastify/pull/5056](https://togithub.com/fastify/fastify/pull/5056)
- [@&#8203;Cadienvan](https://togithub.com/Cadienvan) made their first
contribution in
[https://github.com/fastify/fastify/pull/5079](https://togithub.com/fastify/fastify/pull/5079)
- [@&#8203;arthurfiorette](https://togithub.com/arthurfiorette) made
their first contribution in
[https://github.com/fastify/fastify/pull/5082](https://togithub.com/fastify/fastify/pull/5082)
- [@&#8203;jackbatzner](https://togithub.com/jackbatzner) made their
first contribution in
[https://github.com/fastify/fastify/pull/5088](https://togithub.com/fastify/fastify/pull/5088)

**Full Changelog**:
fastify/fastify@v4.23.2...v4.24.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/redwoodjs/redwood).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40Ni4wIiwidXBkYXRlZEluVmVyIjoiMzcuNDYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
jtoar referenced this pull request in redwoodjs/graphql Nov 16, 2023
@renovate @jtoar
fix(deps): update dependency fastify to v4.24.3 (#9457)
d811da3 
[![Mend Renovate logo
banner](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [fastify](https://www.fastify.dev/)
([source](https://togithub.com/fastify/fastify)) | [`4.23.2` ->
`4.24.3`](https://renovatebot.com/diffs/npm/fastify/4.23.2/4.24.3) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/fastify/4.24.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/fastify/4.24.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/fastify/4.23.2/4.24.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/fastify/4.23.2/4.24.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

<details>
<summary>fastify/fastify (fastify)</summary>

[`v4.24.3`](https://togithub.com/fastify/fastify/releases/tag/v4.24.3)

[Compare
Source](https://togithub.com/fastify/fastify/compare/v4.24.2...v4.24.3)

- fix: timeout on citgm tests by
[@&#8203;simone-sanfratello](https://togithub.com/simone-sanfratello) in
[https://github.com/fastify/fastify/pull/5101](https://togithub.com/fastify/fastify/pull/5101)
- chore: add missing `use strict` directives by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[https://github.com/fastify/fastify/pull/5106](https://togithub.com/fastify/fastify/pull/5106)

**Full Changelog**:
fastify/fastify@v4.24.2...v4.24.3

[`v4.24.2`](https://togithub.com/fastify/fastify/releases/tag/v4.24.2)

[Compare
Source](https://togithub.com/fastify/fastify/compare/v4.24.1...v4.24.2)

- fix: build problems when `Symbol.asyncDispose` type is not available.
by [@&#8203;arthurfiorette](https://togithub.com/arthurfiorette) in
[https://github.com/fastify/fastify/pull/5096](https://togithub.com/fastify/fastify/pull/5096)

**Full Changelog**:
fastify/fastify@v4.24.1...v4.24.2

[`v4.24.1`](https://togithub.com/fastify/fastify/releases/tag/v4.24.1)

[Compare
Source](https://togithub.com/fastify/fastify/compare/v4.24.0...v4.24.1)

- fix: citgm by
[@&#8203;simone-sanfratello](https://togithub.com/simone-sanfratello) in
[https://github.com/fastify/fastify/pull/5075](https://togithub.com/fastify/fastify/pull/5075)
- fix: HEAD route reseting by
[@&#8203;ivan-tymoshenko](https://togithub.com/ivan-tymoshenko) in
[https://github.com/fastify/fastify/pull/5090](https://togithub.com/fastify/fastify/pull/5090)

**Full Changelog**:
fastify/fastify@v4.24.0...v4.24.1

[`v4.24.0`](https://togithub.com/fastify/fastify/releases/tag/v4.24.0)

[Compare
Source](https://togithub.com/fastify/fastify/compare/v4.23.2...v4.24.0)

- docs: Add blank line before onclose hook heading by
[@&#8203;kadoshita](https://togithub.com/kadoshita) in
[https://github.com/fastify/fastify/pull/5042](https://togithub.com/fastify/fastify/pull/5042)
- build(dependabot): ignore tap major updates by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[https://github.com/fastify/fastify/pull/5047](https://togithub.com/fastify/fastify/pull/5047)
- chore: Bump actions/checkout from 3 to 4 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/fastify/fastify/pull/5048](https://togithub.com/fastify/fastify/pull/5048)
- chore: more perf by [@&#8203;Eomm](https://togithub.com/Eomm) in
[https://github.com/fastify/fastify/pull/5016](https://togithub.com/fastify/fastify/pull/5016)
- docs(ecosystem): add fastify-prisma by
[@&#8203;zrosenbauer](https://togithub.com/zrosenbauer) in
[https://github.com/fastify/fastify/pull/5041](https://togithub.com/fastify/fastify/pull/5041)
- test: fix ci due yup breaking by
[@&#8203;Eomm](https://togithub.com/Eomm) in
[https://github.com/fastify/fastify/pull/5058](https://togithub.com/fastify/fastify/pull/5058)
- perf: optimize split params by
[@&#8203;Connormiha](https://togithub.com/Connormiha) in
[https://github.com/fastify/fastify/pull/5057](https://togithub.com/fastify/fastify/pull/5057)
- chore: implicitly infer SchemaCompiler as readonly by
[@&#8203;DemonHa](https://togithub.com/DemonHa) in
[https://github.com/fastify/fastify/pull/5060](https://togithub.com/fastify/fastify/pull/5060)
- test(logger): splitting existing tests to avoid pipeline failing for
timeout by
[@&#8203;giuliowaitforitdavide](https://togithub.com/giuliowaitforitdavide)
in
[https://github.com/fastify/fastify/pull/5064](https://togithub.com/fastify/fastify/pull/5064)
- fix(async-hooks): mixing async and callback style in preHandler option
now returns an error by
[@&#8203;giuliowaitforitdavide](https://togithub.com/giuliowaitforitdavide)
in
[https://github.com/fastify/fastify/pull/5069](https://togithub.com/fastify/fastify/pull/5069)
- fix: enhance 100 and 200 or 204 handling by
[@&#8203;Iamshankhadeep](https://togithub.com/Iamshankhadeep) in
[https://github.com/fastify/fastify/pull/5056](https://togithub.com/fastify/fastify/pull/5056)
- docs: add fastify-cloudflare-turnstile to ecosystem by
[@&#8203;112RG](https://togithub.com/112RG) in
[https://github.com/fastify/fastify/pull/5067](https://togithub.com/fastify/fastify/pull/5067)
- docs: Fixing a couple typos by
[@&#8203;Cadienvan](https://togithub.com/Cadienvan) in
[https://github.com/fastify/fastify/pull/5079](https://togithub.com/fastify/fastify/pull/5079)
- feat: Add `Symbol.asyncDispose` to improve DX in short lived servers.
by [@&#8203;arthurfiorette](https://togithub.com/arthurfiorette) in
[https://github.com/fastify/fastify/pull/5082](https://togithub.com/fastify/fastify/pull/5082)
- docs: Documentation changes requested at
[#&#8203;5082](https://togithub.com/fastify/fastify/issues/5082) by
[@&#8203;arthurfiorette](https://togithub.com/arthurfiorette) in
[https://github.com/fastify/fastify/pull/5083](https://togithub.com/fastify/fastify/pull/5083)
- docs: remove thenable promisesaplus spec references by
[@&#8203;dancastillo](https://togithub.com/dancastillo) in
[https://github.com/fastify/fastify/pull/5081](https://togithub.com/fastify/fastify/pull/5081)
- docs(ecosystem): add fastify-event-bus by
[@&#8203;Shiva127](https://togithub.com/Shiva127) in
[https://github.com/fastify/fastify/pull/5085](https://togithub.com/fastify/fastify/pull/5085)
- docs: update docs for FastifyPlugin by
[@&#8203;dancastillo](https://togithub.com/dancastillo) in
[https://github.com/fastify/fastify/pull/5070](https://togithub.com/fastify/fastify/pull/5070)
- docs: Update for .hijack heading by
[@&#8203;jackbatzner](https://togithub.com/jackbatzner) in
[https://github.com/fastify/fastify/pull/5088](https://togithub.com/fastify/fastify/pull/5088)
- fix(warnings): fixed warning when accessing context property from
Request and Reply objects by
[@&#8203;giuliowaitforitdavide](https://togithub.com/giuliowaitforitdavide)
in
[https://github.com/fastify/fastify/pull/5084](https://togithub.com/fastify/fastify/pull/5084)
- fix: HEAD route search by
[@&#8203;ivan-tymoshenko](https://togithub.com/ivan-tymoshenko) in
[https://github.com/fastify/fastify/pull/5078](https://togithub.com/fastify/fastify/pull/5078)

- [@&#8203;kadoshita](https://togithub.com/kadoshita) made their first
contribution in
[https://github.com/fastify/fastify/pull/5042](https://togithub.com/fastify/fastify/pull/5042)
- [@&#8203;Connormiha](https://togithub.com/Connormiha) made their first
contribution in
[https://github.com/fastify/fastify/pull/5057](https://togithub.com/fastify/fastify/pull/5057)
- [@&#8203;DemonHa](https://togithub.com/DemonHa) made their first
contribution in
[https://github.com/fastify/fastify/pull/5060](https://togithub.com/fastify/fastify/pull/5060)
- [@&#8203;Iamshankhadeep](https://togithub.com/Iamshankhadeep) made
their first contribution in
[https://github.com/fastify/fastify/pull/5056](https://togithub.com/fastify/fastify/pull/5056)
- [@&#8203;Cadienvan](https://togithub.com/Cadienvan) made their first
contribution in
[https://github.com/fastify/fastify/pull/5079](https://togithub.com/fastify/fastify/pull/5079)
- [@&#8203;arthurfiorette](https://togithub.com/arthurfiorette) made
their first contribution in
[https://github.com/fastify/fastify/pull/5082](https://togithub.com/fastify/fastify/pull/5082)
- [@&#8203;jackbatzner](https://togithub.com/jackbatzner) made their
first contribution in
[https://github.com/fastify/fastify/pull/5088](https://togithub.com/fastify/fastify/pull/5088)

**Full Changelog**:
fastify/fastify@v4.23.2...v4.24.0

</details>

---

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/redwoodjs/redwood).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40Ni4wIiwidXBkYXRlZEluVmVyIjoiMzcuNDYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@github-actions

github-actions Bot commented Sep 19, 2024

Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Sep 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@gurgunday gurgunday gurgunday left review comments
@mcollina mcollina mcollina approved these changes
@Uzlopak Uzlopak Uzlopak approved these changes
@metcoder95 metcoder95 metcoder95 approved these changes
+1 more reviewer
@rozzilla rozzilla rozzilla approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

chore Small changes or internal project maintenance performances Everything related to performances

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Eomm @gurgunday @mcollina @rozzilla @Uzlopak @metcoder95