docs: adding reference guide by lirantal · Pull Request #144 · fastify/env-schema

lirantal · 2022-12-25T09:51:25Z

Adding a section to list helpful resource guides to get started with building with env-schema

Fixes #142

Checklist

run npm run test and npm run benchmark
tests and/or benchmarks are included
documentation is changed or added
commit message and code follows the Developer's Certification of Origin
and the Code of conduct

adding a section to list helpful resource guides to get started with building with env-schema

mcollina · 2022-12-25T22:36:05Z

Could you split creation of the Fastify application with the call to listen in two files, as this enables testing without using globals?

lirantal · 2022-12-26T10:51:54Z

Sure thing. I was going for simplicity there but have merged a PR to change that to a more modular structure: lirantal/fastify-dotenv-envschema-example#1 (landed in main already)

README.md

Co-authored-by: Frazer Smith <frazer.dev@outlook.com>

climba03003

Shouldn't it place in @fastify/env when you did not directly using env-schema?

lirantal · 2022-12-26T19:32:20Z

It's a good question and I was asking myself the same thing but I thought the ideal place is here because folks using the @fastify/env plugin would probably already know best practices and how to use it, yet new folks landing on this repository might look for how to get started and how they can use env-schema, especially since it doesn't have anything to do with Fastify as the app framework itself, but just happens to live on this org.

So, I'd keep it here to be more helpful but happy to move elsewhere if you think it'd be a better fit.

mcollina · 2022-12-28T18:33:34Z

I personally find env-schema better and I don't use fastify-env ;).

lirantal · 2022-12-30T10:50:29Z

fastify-env is pretty small and is anyway just a wrapper around env-schema though, isn't it? I figured if you don't use fastify-env you probably just do the same plugging wrapping yourself.

mcollina · 2022-12-30T11:22:16Z

I tend to not wrap this into a plugin, but rather read it before Fastify is started. In this way I can customize the options of Fastify itself

jsumners · 2022-12-30T15:01:17Z

I tend to not wrap this into a plugin, but rather read it before Fastify is started. In this way I can customize the options of Fastify itself

Agreed. I really don't understand the point of fastify-env.

'use strict'

const dotenv = require('dotenv')
const config = dotenv.config()

const fastify = require('fastify')({ /* use stuff from config */})
fastify.decorate('env', {
  getter() { return config }
})

mcollina

lgtm

docs: adding reference guide

1c51f40

adding a section to list helpful resource guides to get started with building with env-schema

Fdawgs requested changes Dec 26, 2022

View reviewed changes

README.md Outdated Show resolved Hide resolved

Update README.md

c729942

Co-authored-by: Frazer Smith <frazer.dev@outlook.com>

Fdawgs approved these changes Dec 26, 2022

View reviewed changes

climba03003 reviewed Dec 26, 2022

View reviewed changes

Fdawgs requested a review from mcollina July 29, 2023 08:07

mcollina approved these changes Jul 31, 2023

View reviewed changes

mcollina merged commit 96535da into fastify:master Jul 31, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs: adding reference guide#144

docs: adding reference guide#144
mcollina merged 2 commits intofastify:masterfrom
lirantal:patch-1

lirantal commented Dec 25, 2022 •

edited by Fdawgs

Loading

Uh oh!

mcollina commented Dec 25, 2022

Uh oh!

lirantal commented Dec 26, 2022

Uh oh!

Uh oh!

climba03003 left a comment

Uh oh!

lirantal commented Dec 26, 2022

Uh oh!

mcollina commented Dec 28, 2022

Uh oh!

lirantal commented Dec 30, 2022

Uh oh!

mcollina commented Dec 30, 2022

Uh oh!

jsumners commented Dec 30, 2022

Uh oh!

mcollina left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

lirantal commented Dec 25, 2022 • edited by Fdawgs Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

mcollina commented Dec 25, 2022

Uh oh!

lirantal commented Dec 26, 2022

Uh oh!

Uh oh!

climba03003 left a comment

Choose a reason for hiding this comment

Uh oh!

lirantal commented Dec 26, 2022

Uh oh!

mcollina commented Dec 28, 2022

Uh oh!

lirantal commented Dec 30, 2022

Uh oh!

mcollina commented Dec 30, 2022

Uh oh!

jsumners commented Dec 30, 2022

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

lirantal commented Dec 25, 2022 •

edited by Fdawgs

Loading