Skip to content

feat(locale): add airline database science commerce and vehicle for zh_CN#2395

Merged
ST-DDT merged 22 commits intofaker-js:nextfrom
CoolPlayLin:zh_CN/new_modules
Sep 29, 2023
Merged

feat(locale): add airline database science commerce and vehicle for zh_CN#2395
ST-DDT merged 22 commits intofaker-js:nextfrom
CoolPlayLin:zh_CN/new_modules

Conversation

@CoolPlayLin
Copy link
Copy Markdown
Contributor

@CoolPlayLin CoolPlayLin commented Sep 16, 2023 •
edited
Loading

Translation Work Status 📋

  • airline
  • database
  • science
  • commerce
  • vehicle

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 16, 2023 •
edited
Loading

Codecov Report

Merging #2395 (85c820c) into next (dd21c0f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff            @@
##             next    #2395     +/-   ##
=========================================
  Coverage   99.61%   99.61%             
=========================================
  Files        2802     2820     +18     
  Lines      252492   253880   +1388     
  Branches     1104     1105      +1     
=========================================
+ Hits       251517   252908   +1391     
+ Misses        948      945      -3     
  Partials       27       27
Files Coverage Δ
src/locales/zh_CN/airline/airline.ts 100.00% <100.00%> (ø)
src/locales/zh_CN/airline/airplane.ts 100.00% <100.00%> (ø)
src/locales/zh_CN/airline/airport.ts 100.00% <100.00%> (ø)
src/locales/zh_CN/airline/index.ts 100.00% <100.00%> (ø)
src/locales/zh_CN/commerce/department.ts 100.00% <100.00%> (ø)
src/locales/zh_CN/commerce/index.ts 100.00% <100.00%> (ø)
src/locales/zh_CN/commerce/product_description.ts 100.00% <100.00%> (ø)
src/locales/zh_CN/commerce/product_name.ts 100.00% <100.00%> (ø)
src/locales/zh_CN/database/column.ts 100.00% <100.00%> (ø)
src/locales/zh_CN/database/index.ts 100.00% <100.00%> (ø)
... and 9 more

... and 1 file with indirect coverage changes

matthewmayer
matthewmayer reviewed Sep 16, 2023
View reviewed changes
Comment thread src/locales/zh_CN/team/creature.ts Outdated
@CoolPlayLin CoolPlayLin changed the title feat(locale): add airline database science and vehicle for zh_CN [WIP] feat(locale): add airline database science commerce and vehicle for zh_CN [WIP] Sep 16, 2023
@CoolPlayLin CoolPlayLin marked this pull request as ready for review September 17, 2023 01:56
@CoolPlayLin CoolPlayLin requested a review from a team as a code owner September 17, 2023 01:56
@CoolPlayLin CoolPlayLin changed the title feat(locale): add airline database science commerce and vehicle for zh_CN [WIP] feat(locale): add airline database science commerce and vehicle for zh_CN Sep 17, 2023
ST-DDT
ST-DDT reviewed Sep 17, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I try to review the remaining parts this PR later.
This might take a while.

Comment thread src/locales/zh_CN/airline/airline.ts
Comment thread src/locales/zh_CN/science/unit.ts
@ST-DDT ST-DDT added this to the vAnytime milestone Sep 17, 2023
@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: locale Permutes locale definitions labels Sep 17, 2023
@CoolPlayLin CoolPlayLin requested a review from ST-DDT September 23, 2023 04:59
@CoolPlayLin CoolPlayLin requested a review from ejcheng September 23, 2023 04:59
@xDivisionByZerox xDivisionByZerox added m: commerce Something is referring to the commerce module m: database Something is referring to the database module m: science Something is referring to the science module m: vehicle Something is referring to the vehicle module m: airline Something is referring to the airline module labels Sep 28, 2023
xDivisionByZerox
xDivisionByZerox approved these changes Sep 28, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@xDivisionByZerox xDivisionByZerox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Some values had not a literal translation, but I guess that those are still fine.

Next time, put separate modules into separate pull requests, please. Thank you :)

@ST-DDT ST-DDT enabled auto-merge (squash) September 29, 2023 20:14
@ST-DDT ST-DDT merged commit 9c96c0a into faker-js:next Sep 29, 2023
@CoolPlayLin CoolPlayLin deleted the zh_CN/new_modules branch September 30, 2023 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

@matthewmayer matthewmayer Awaiting requested review from matthewmayer

@ejcheng ejcheng Awaiting requested review from ejcheng

Assignees

No one assigned

Labels

c: locale Permutes locale definitions m: airline Something is referring to the airline module m: commerce Something is referring to the commerce module m: database Something is referring to the database module m: science Something is referring to the science module m: vehicle Something is referring to the vehicle module p: 1-normal Nothing urgent

Projects

None yet

Milestone

vAnytime

Development

Successfully merging this pull request may close these issues.

5 participants

@CoolPlayLin @matthewmayer @ST-DDT @ejcheng @xDivisionByZerox