Skip to content

feat(locale): add word category for da#2359

Merged
ST-DDT merged 1 commit intofaker-js:nextfrom
stonor:da-locale-word
Sep 1, 2023
Merged

feat(locale): add word category for da#2359
ST-DDT merged 1 commit intofaker-js:nextfrom
stonor:da-locale-word

Conversation

@stonor
Copy link
Copy Markdown
Contributor

@stonor stonor commented Aug 30, 2023

Source: hand picked words with a little help from the Spacy POS tagger (that identifies word classes from e.g. Wikipedia documents).

@stonor stonor requested a review from a team as a code owner August 30, 2023 09:50
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 30, 2023

Codecov Report

Merging #2359 (bb31d95) into next (8e4ea67) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2359      +/-   ##
==========================================
- Coverage   99.61%   99.60%   -0.01%     
==========================================
  Files        2752     2760       +8     
  Lines      250523   251164     +641     
  Branches     1086     1080       -6     
==========================================
+ Hits       249559   250173     +614     
- Misses        937      964      +27     
  Partials       27       27              
Files Changed Coverage Δ
src/locales/da/index.ts 100.00% <100.00%> (ø)
src/locales/da/word/adjective.ts 100.00% <100.00%> (ø)
src/locales/da/word/adverb.ts 100.00% <100.00%> (ø)
src/locales/da/word/conjunction.ts 100.00% <100.00%> (ø)
src/locales/da/word/index.ts 100.00% <100.00%> (ø)
src/locales/da/word/interjection.ts 100.00% <100.00%> (ø)
src/locales/da/word/noun.ts 100.00% <100.00%> (ø)
src/locales/da/word/preposition.ts 100.00% <100.00%> (ø)
src/locales/da/word/verb.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@ST-DDT ST-DDT added c: feature Request for new feature p: 1-normal Nothing urgent m: word Something is referring to the word module labels Aug 30, 2023
@ST-DDT ST-DDT requested review from a team August 30, 2023 17:42
@ST-DDT ST-DDT changed the title feat(locale): add data for word category for da feat(locale): add word category for da Sep 1, 2023
@ST-DDT ST-DDT merged commit 8e5bc22 into faker-js:next Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: feature Request for new feature m: word Something is referring to the word module p: 1-normal Nothing urgent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants