Skip to content

feat(locale): add GB subdivision codes#2233

Merged
ST-DDT merged 5 commits intofaker-js:nextfrom
RobinvanderVliet:add-uk-cubdivision-codes
Jul 9, 2023
Merged

feat(locale): add GB subdivision codes#2233
ST-DDT merged 5 commits intofaker-js:nextfrom
RobinvanderVliet:add-uk-cubdivision-codes

Conversation

@RobinvanderVliet
Copy link
Copy Markdown
Contributor

@RobinvanderVliet RobinvanderVliet requested a review from a team as a code owner July 1, 2023 20:24
@ejcheng ejcheng requested a review from a team July 1, 2023 21:41
@ejcheng ejcheng added p: 1-normal Nothing urgent c: locale Permutes locale definitions labels Jul 1, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 1, 2023

Codecov Report

Merging #2233 (1e105c7) into next (4a15bd0) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2233   +/-   ##
=======================================
  Coverage   99.59%   99.60%           
=======================================
  Files        2640     2641    +1     
  Lines      245757   245760    +3     
  Branches     1155     1156    +1     
=======================================
+ Hits       244770   244780   +10     
+ Misses        960      953    -7     
  Partials       27       27           
Impacted Files Coverage Δ
src/locales/en_GB/location/index.ts 100.00% <100.00%> (ø)
src/locales/en_GB/location/state.ts 100.00% <100.00%> (ø)
src/locales/en_GB/location/state_abbr.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@xDivisionByZerox xDivisionByZerox added c: feature Request for new feature s: accepted Accepted feature / Confirmed bug m: location Something is referring to the location module labels Jul 1, 2023
ST-DDT
ST-DDT previously approved these changes Jul 2, 2023
ejcheng
ejcheng previously approved these changes Jul 2, 2023
@ST-DDT ST-DDT changed the title feat(locale): Add UK subdivision codes feat(locale): Add GB subdivision codes Jul 9, 2023
@ST-DDT ST-DDT changed the title feat(locale): Add GB subdivision codes feat(locale): add GB subdivision codes Jul 9, 2023
@ST-DDT ST-DDT enabled auto-merge (squash) July 9, 2023 08:48
@ST-DDT ST-DDT merged commit 5eec65f into faker-js:next Jul 9, 2023
@RobinvanderVliet RobinvanderVliet deleted the add-uk-cubdivision-codes branch July 9, 2023 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: feature Request for new feature c: locale Permutes locale definitions m: location Something is referring to the location module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants