feat(locale): support color and date for zh_CN#2223
Merged
ST-DDT merged 5 commits intofaker-js:nextfrom Jun 25, 2023
Merged
Conversation
ST-DDT
reviewed
Jun 23, 2023
ST-DDT
previously approved these changes
Jun 23, 2023
Member
|
Looks good to me. Thanks for your contribution ❤️ ! |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #2223 +/- ##
==========================================
- Coverage 99.60% 99.59% -0.02%
==========================================
Files 2632 2637 +5
Lines 245581 245674 +93
Branches 1156 1153 -3
==========================================
+ Hits 244616 244681 +65
- Misses 938 966 +28
Partials 27 27
|
ejcheng
previously approved these changes
Jun 23, 2023
Member
|
All entries are valid, lgtm |
matthewmayer
requested changes
Jun 24, 2023
matthewmayer
previously approved these changes
Jun 24, 2023
ST-DDT
approved these changes
Jun 24, 2023
ejcheng
approved these changes
Jun 24, 2023
matthewmayer
approved these changes
Jun 25, 2023
Member
|
Once again: Thanks for your contribution ❤️ |
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
support color and date for zh_CN