fix(locale): remove duplicated countries in ja locale#2189
Merged
ST-DDT merged 5 commits intofaker-js:nextfrom Jun 4, 2023
Merged
Conversation
Signed-off-by: KeisukeYamashita <19yamashita15@gmail.com>
Signed-off-by: KeisukeYamashita <19yamashita15@gmail.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #2189 +/- ##
==========================================
- Coverage 99.60% 99.59% -0.01%
==========================================
Files 2607 2607
Lines 245021 245017 -4
Branches 1154 1153 -1
==========================================
- Hits 244043 244034 -9
- Misses 951 956 +5
Partials 27 27
|
ST-DDT
previously approved these changes
Jun 1, 2023
ja local
xDivisionByZerox
previously approved these changes
Jun 1, 2023
ja locale
ejcheng
previously approved these changes
Jun 1, 2023
Signed-off-by: KeisukeYamashita <19yamashita15@gmail.com>
cc0bc83
Contributor
Author
|
@faker-jp/maintainers Sorry, I noticed that PTAL again when you got chance, thank you in advance!!! |
matthewmayer
approved these changes
Jun 2, 2023
xDivisionByZerox
approved these changes
Jun 2, 2023
ejcheng
approved these changes
Jun 4, 2023
ST-DDT
approved these changes
Jun 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, Faker team!
Thank you for the great work.
I'm currently developing a product in Japan and I'm trying to use the Faker with
jalocal for my unit testing.I have realized that there are duplicated entries in the countries list
濠洲===オーストラリア(Ref: オーストラリア、ウィキペディア)蒙古===モンゴル(Ref: モンゴル国、ウィキペディア)米国=== `アメリカ (Ref: アメリカ合衆国, ウィキペディア)英国===イギリス(Ref: イギリス、ウィキペディア)Moreover, Kanji character country names are abbreviations and not official indications, thus it's only used in limited cases and it should be excluded from this list.