Skip to content

fix(locale): ro_MD city should be city_pattern#2155

Merged
ST-DDT merged 2 commits intofaker-js:nextfrom
matthewmayer:ro-md-city-pattern
May 25, 2023
Merged

fix(locale): ro_MD city should be city_pattern#2155
ST-DDT merged 2 commits intofaker-js:nextfrom
matthewmayer:ro-md-city-pattern

Conversation

@matthewmayer
Copy link
Copy Markdown
Contributor

conflict of #2084 and #2094

@matthewmayer matthewmayer requested a review from a team as a code owner May 13, 2023 09:55
@matthewmayer matthewmayer self-assigned this May 13, 2023
@matthewmayer matthewmayer changed the title fix(locale) ro_MD city should be city_pattern fix(locale): ro_MD city should be city_pattern May 13, 2023
@matthewmayer matthewmayer added p: 1-normal Nothing urgent c: locale Permutes locale definitions labels May 13, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented May 13, 2023

Codecov Report

Merging #2155 (30c6e3d) into next (d4a25f6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 30c6e3d differs from pull request most recent head 4688854. Consider uploading reports for the commit 4688854 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2155   +/-   ##
=======================================
  Coverage   99.60%   99.60%           
=======================================
  Files        2607     2607           
  Lines      244977   244977           
  Branches     1148     1149    +1     
=======================================
+ Hits       244001   244009    +8     
+ Misses        949      941    -8     
  Partials       27       27           
Impacted Files Coverage Δ
src/locales/ro_MD/location/city_pattern.ts 100.00% <ø> (ø)
src/locales/ro_MD/location/index.ts 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

@matthewmayer matthewmayer added the m: location Something is referring to the location module label May 13, 2023
@ST-DDT ST-DDT enabled auto-merge (squash) May 25, 2023 21:06
@ST-DDT ST-DDT merged commit c173150 into faker-js:next May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: locale Permutes locale definitions m: location Something is referring to the location module p: 1-normal Nothing urgent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants