feat(metadata): add method to access metadata#2143
Merged
ST-DDT merged 9 commits intofaker-js:nextfrom Jun 17, 2023
Merged
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #2143 +/- ##
==========================================
- Coverage 99.59% 99.59% -0.01%
==========================================
Files 2623 2623
Lines 245491 245504 +13
Branches 1149 1152 +3
==========================================
+ Hits 244503 244514 +11
- Misses 961 963 +2
Partials 27 27
|
ST-DDT
reviewed
May 9, 2023
Co-authored-by: ST-DDT <ST-DDT@gmx.de>
ST-DDT
requested changes
May 10, 2023
ST-DDT
previously approved these changes
May 10, 2023
Member
xDivisionByZerox
left a comment
There was a problem hiding this comment.
I'm a bit conflicted about why we extract the metaobject access from the definitions. Currently, you can access them fine just fine via faker.definitions.metadata. What is the benefit of the implementation of this PR?
Contributor
Author
|
Co-authored-by: DivisionByZero <leyla.jaehnig@gmx.de>
xDivisionByZerox
approved these changes
May 14, 2023
ST-DDT
approved these changes
May 24, 2023
Member
|
Do not merge yet, so we can release a v8.0.2 the next few days |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #1984