noCodeFrame respects noStackTrace#9866
Merged
SimenB merged 6 commits intojestjs:masterfrom Apr 23, 2020
Merged
Conversation
SimenB
approved these changes
Apr 22, 2020
| 'path_test', | ||
| ); | ||
|
|
||
| expect(message).toMatchSnapshot(); |
Member
There was a problem hiding this comment.
Suggested change
| expect(message).toMatchSnapshot(); | |
| expect(wrap(message)).toMatchSnapshot(); |
import {wrap} from 'jest-snapshot-serializer-raw';
will get rid of the wrapping "`.
Please apply to both 😀
Member
|
@ychi ah no sorry, these use ansi. I take it all back, please revert last commit 😅 |
This reverts commit 216971c.
Contributor
Author
|
@SimenB, thank you for helping to revert. There seems to be an CI error for windows before adding |
Member
|
@ychi seems transient to me, let's see what CI says now 🙂 |
Codecov Report
@@ Coverage Diff @@
## master #9866 +/- ##
=======================================
Coverage 64.39% 64.39%
=======================================
Files 290 290
Lines 12361 12361
Branches 3056 3054 -2
=======================================
Hits 7960 7960
Misses 3761 3761
Partials 640 640
Continue to review full report at Codecov.
|
jeysal
added a commit
to mmkal/jest
that referenced
this pull request
Apr 26, 2020
…pshots * upstream/master: (39 commits) Prints the Symbol name into the error message with a custom asymmetric matcher (jestjs#9888) Show coverage of sources related to tests in changed files (jestjs#9769) fix: don't /// <reference types="jest" /> (jestjs#9875) noCodeFrame respects noStackTrace (jestjs#9866) chore: update example to react-native@0.62 (jestjs#9746) Improve source map handling when instrumenting transformed code (jestjs#9811) Update .vscode/launch.json settings (jestjs#9868) chore: verify all packages have the same engine requirement (jestjs#9871) fix: pass custom cached realpath function to `resolve` (jestjs#9873) chore: mock stealthy-require in tests (jestjs#9855) chore: update resolve (jestjs#9872) chore: run CircleCI on node 14 (jestjs#9870) Add an option to vscode settings to always use workspace TS (jestjs#9869) fix(esm): handle parallel imports (jestjs#9858) chore: run CI on Node 14 (jestjs#9861) feat: add `@jest/globals` package for importing globals explici… (jestjs#9849) chore: bump resolve package (jestjs#9859) chore(runtime): simplify `createJestObjectFor` (jestjs#9857) chore: fix symlink creation failures on windows in tests (jestjs#9852) chore: skip mercurial tests when no hg installed (jestjs#9840) ...
jeysal
added a commit
to mmkal/jest
that referenced
this pull request
Apr 26, 2020
…pshots * upstream/master: (39 commits) Prints the Symbol name into the error message with a custom asymmetric matcher (jestjs#9888) Show coverage of sources related to tests in changed files (jestjs#9769) fix: don't /// <reference types="jest" /> (jestjs#9875) noCodeFrame respects noStackTrace (jestjs#9866) chore: update example to react-native@0.62 (jestjs#9746) Improve source map handling when instrumenting transformed code (jestjs#9811) Update .vscode/launch.json settings (jestjs#9868) chore: verify all packages have the same engine requirement (jestjs#9871) fix: pass custom cached realpath function to `resolve` (jestjs#9873) chore: mock stealthy-require in tests (jestjs#9855) chore: update resolve (jestjs#9872) chore: run CircleCI on node 14 (jestjs#9870) Add an option to vscode settings to always use workspace TS (jestjs#9869) fix(esm): handle parallel imports (jestjs#9858) chore: run CI on Node 14 (jestjs#9861) feat: add `@jest/globals` package for importing globals explici… (jestjs#9849) chore: bump resolve package (jestjs#9859) chore(runtime): simplify `createJestObjectFor` (jestjs#9857) chore: fix symlink creation failures on windows in tests (jestjs#9852) chore: skip mercurial tests when no hg installed (jestjs#9840) ...
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
--noStackTraceflag is set, code frames should not be printed as mentioned hereTest plan
New snapshot test cases added.