Skip to content

fix(core): normalize slashes for url/baseUrl instead of throwing#8066

Merged
slorber merged 1 commit into
mainfrom
jc/normalize-url
Sep 8, 2022
Merged

fix(core): normalize slashes for url/baseUrl instead of throwing#8066
slorber merged 1 commit into
mainfrom
jc/normalize-url

Conversation

@Josh-Cena

@Josh-Cena Josh-Cena commented Sep 8, 2022

Copy link
Copy Markdown
Collaborator

Pre-flight checklist

Motivation

Test Plan

Testing the SiteMetadata is a bit unwieldy atm, so I only wrote validation tests.

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

@Josh-Cena Josh-Cena added pr: polish This PR adds a very minor behavior improvement that users will enjoy. to backport This PR is planned to be backported to a stable version of Docusaurus labels Sep 8, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Sep 8, 2022
@netlify

netlify Bot commented Sep 8, 2022 •
edited
Loading

Copy link
Copy Markdown

✅ [V2]

Name Link
🔨 Latest commit 271e7a2
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/63196ea786d9490009680e84
😎 Deploy Preview https://deploy-preview-8066--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions

github-actions Bot commented Sep 8, 2022 •
edited
Loading

Copy link
Copy Markdown

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 82 🟢 98 🟢 100 🟢 100 🟠 80 Report
/docs/installation 🟠 76 🟢 100 🟢 100 🟢 100 🟢 90 Report

@github-actions

github-actions Bot commented Sep 8, 2022 •
edited
Loading

Copy link
Copy Markdown

Size Change: 0 B

Total Size: 813 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 52.1 kB
website/build/assets/css/styles.********.css 111 kB
website/build/assets/js/main.********.js 609 kB
website/build/index.html 40.8 kB

compressed-size-action

slorber
slorber approved these changes Sep 8, 2022
View reviewed changes

@slorber slorber left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks 👍

@slorber slorber merged commit bcae750 into main Sep 8, 2022
@slorber slorber deleted the jc/normalize-url branch September 8, 2022 15:18
@slorber slorber mentioned this pull request Oct 27, 2022
Closed
2 tasks
slorber pushed a commit that referenced this pull request Oct 28, 2022
@Josh-Cena @slorber
fix(core): normalize slashes for url/baseUrl instead of throwing (#8066)
c7301f5
@slorber slorber added backported This PR has been backported to a stable version of Docusaurus and removed to backport This PR is planned to be backported to a stable version of Docusaurus labels Nov 2, 2022
@slorber slorber mentioned this pull request Oct 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@slorber slorber slorber approved these changes

@lex111 lex111 Awaiting requested review from lex111

Assignees

No one assigned

Labels

backported This PR has been backported to a stable version of Docusaurus CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Site config url + baseUrl are not normalized and sensitive to leading/trailing slash

3 participants

@Josh-Cena @slorber @facebook-github-bot