refactor(theme): remove hard-coded tag border-radius#8062
Merged
Conversation
.tagRegular should use `--ifm-global-radius` instead of a hardcoded 0.5rem radius.
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the deploy preview of this PR
|
Collaborator
|
LGTM 👍 this reduces a bit the radius (0.5rem -> 0.4rem) but actually looks better |
slorber
pushed a commit
that referenced
this pull request
Oct 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-flight checklist
Motivation
.tagRegular has a fixed 0.5REM border radius - it's the only place I've found that doesn't inherit from
--ifm-global-radiuswithout a good reason.Test Plan
Default behaviour here will be no change unless
--ifm-global-radiusis customised in which case tag elements will now inherit.Test links
Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/
Related issues/PRs