fix: fix panic when optional chain partially replaced with defines#3554
Merged
evanw merged 5 commits intoevanw:mainfrom Dec 18, 2023
Merged
fix: fix panic when optional chain partially replaced with defines#3554evanw merged 5 commits intoevanw:mainfrom
evanw merged 5 commits intoevanw:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3551
Hi, I just started to explore code base for this opportunity to investigate the issue further. Probably this change is not the most appropriate fix, but for the sake of showing what I found so far, I'm making this draft PR first.
I would appreciate if you could provide any guidance on more principled fix (Or if you have a plan to fix in a different PR, then I'm happy to close this PR as well).
Btw, I love esbuild. Thanks a lot for making this awesome tool!