docs: update require-unicode-regexp.md as following up #17402#17441
Merged
Conversation
✅ Deploy Preview for docs-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
Author
|
A workflow has been failed but it isn't related to this PR changes. The token at https://github.com/eslint/eslint/blob/main/.github/workflows/add-to-triage.yml#L19 seems to be invalid? |
Contributor
Author
|
The same workflow in #17439 is passed. So maybe the secret can't be used in PRs from people who don't have permission to write to the repository...? |
Member
Yes, that seems to be the problem. We're working on the fix, isn't a blocker for merging this PR. |
mdjermanovic
approved these changes
Aug 1, 2023
nzakas
reviewed
Aug 2, 2023
nzakas
approved these changes
Aug 2, 2023
nzakas
left a comment
Member
There was a problem hiding this comment.
I cleaned up a bit of the language. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Address review comments in #17402
Is there anything you'd like reviewers to focus on?