feat: add new `allowLineSeparatedGroups` option to the `sort-keys` rule by snitin315 · Pull Request #16138 · eslint/eslint

snitin315 · 2022-07-17T03:05:44Z

Prerequisites checklist

I have read the contributing guidelines.

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[x] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Fixes #12759

Add new allowLineSeparatedGroups option to the sort-keys rule.

/*eslint sort-keys: ["error", "asc", {allowLineSeparatedGroups: true}]*//

var obj = {
    b: 1,
    c: 2,

    a: 3, // no error
    d: 4
};

See docs preview for more cases.

Is there anything you'd like reviewers to focus on?

No

netlify · 2022-07-17T03:05:49Z

✅ Deploy Preview for docs-eslint ready!

Name	Link
🔨 Latest commit	`45f52f1`
🔍 Latest deploy log	https://app.netlify.com/sites/docs-eslint/deploys/62da1589ade79500088f9fb1
😎 Deploy Preview	https://deploy-preview-16138--docs-eslint.netlify.app/rules/sort-keys
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

mdjermanovic

LGTM, thanks!

I'll leave this open in case someone else wants to review it before merging.

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [eslint](https://eslint.org) ([source](https://github.com/eslint/eslint)) | devDependencies | minor | [`8.20.0` -> `8.21.0`](https://renovatebot.com/diffs/npm/eslint/8.20.0/8.21.0) | --- ### Release Notes <details> <summary>eslint/eslint</summary> ### [`v8.21.0`](https://github.com/eslint/eslint/releases/tag/v8.21.0) [Compare Source](eslint/eslint@v8.20.0...v8.21.0) #### Features - [`7b43ea1`](eslint/eslint@7b43ea1) feat: Implement FlatESLint ([#16149](eslint/eslint#16149)) (Nicholas C. Zakas) - [`92bf49a`](eslint/eslint@92bf49a) feat: improve the key width calculation in `key-spacing` rule ([#16154](eslint/eslint#16154)) (Nitin Kumar) - [`c461542`](eslint/eslint@c461542) feat: add new `allowLineSeparatedGroups` option to the `sort-keys` rule ([#16138](eslint/eslint#16138)) (Nitin Kumar) - [`1cdcbca`](eslint/eslint@1cdcbca) feat: add deprecation warnings for legacy API in `RuleTester` ([#16063](eslint/eslint#16063)) (Nitin Kumar) #### Bug Fixes - [`0396775`](eslint/eslint@0396775) fix: lines-around-comment apply `allowBlockStart` for switch statements ([#16153](eslint/eslint#16153)) (Nitin Kumar) #### Documentation - [`2aadc93`](eslint/eslint@2aadc93) docs: add anchors to headings inside docs content ([#16134](eslint/eslint#16134)) (Strek) #### Chores - [`8892511`](eslint/eslint@8892511) chore: Upgrade to Espree 9.3.3 ([#16173](eslint/eslint#16173)) (Brandon Mills) - [`1233bee`](eslint/eslint@1233bee) chore: switch to eslint-plugin-node's maintained fork ([#16150](eslint/eslint#16150)) (唯然) - [`97b95c0`](eslint/eslint@97b95c0) chore: upgrade puppeteer v13 ([#16151](eslint/eslint#16151)) (唯然) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1483 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>

Adapted from eslint/eslint#16138

feat: add new allowLineSeparatedGroups option to sort-keys rule

6cc0ed8

eslint-github-bot Bot added triage An ESLint team member will look at this issue soon feature This change adds a new feature to ESLint labels Jul 17, 2022

chore: cleanup

016fb1e

snitin315 mentioned this pull request Jul 17, 2022

feat: add allowLineSeparatedGroups option to sort-keys (fixes #12759) #13573

Closed

1 task

snitin315 added 3 commits July 17, 2022 09:36

test: add more cases

321d618

docs: add allowLineSeparatedGroups options

0df5387

docs: add allowLineSeparatedGroups options

c6a9f9d

snitin315 marked this pull request as ready for review July 17, 2022 05:32

mdjermanovic added enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules accepted There is consensus among the team that this change meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels Jul 17, 2022

mdjermanovic reviewed Jul 17, 2022

View reviewed changes

Comment thread lib/rules/sort-keys.js

fix: remove false negatives

3c44101

mdjermanovic reviewed Jul 18, 2022

View reviewed changes

Comment thread lib/rules/sort-keys.js

fix: check blank line between the first token and the previous node

4c2ba24

mdjermanovic reviewed Jul 21, 2022

View reviewed changes

Comment thread lib/rules/sort-keys.js Outdated

mdjermanovic reviewed Jul 21, 2022

View reviewed changes

Comment thread docs/src/rules/sort-keys.md

Comment thread docs/src/rules/sort-keys.md Outdated

refactor: use getTokensBetween and update examples

45f52f1

snitin315 requested a review from mdjermanovic July 24, 2022 10:42

mdjermanovic approved these changes Jul 25, 2022

View reviewed changes

snitin315 merged commit c461542 into main Jul 30, 2022

snitin315 deleted the feat/allowLineSeparatedGroups-options branch July 30, 2022 12:58

sync-by-unito Bot mentioned this pull request Aug 1, 2022

build(deps-dev): bump eslint from 7.32.0 to 8.21.0 numbersprotocol/capture-cam#1868

Closed

sync-by-unito Bot mentioned this pull request Sep 1, 2022

build(deps-dev): bump eslint from 7.32.0 to 8.23.0 numbersprotocol/capture-cam#2013

Closed

forivall added a commit to forivall/eslint-plugin-sort-keys-plus that referenced this pull request Oct 24, 2022

feat: add new allowLineSeparatedGroups option

ec6eea4

Adapted from eslint/eslint#16138

forivall added a commit to forivall/eslint-plugin-sort-keys-plus that referenced this pull request Oct 24, 2022

feat: add new allowLineSeparatedGroups option

41a953d

Adapted from eslint/eslint#16138

forivall added a commit to forivall/eslint-plugin-sort-keys-plus that referenced this pull request Oct 24, 2022

feat: add new allowLineSeparatedGroups option

ce76d95

Adapted from eslint/eslint#16138

forivall added a commit to forivall/eslint-plugin-sort-keys-plus that referenced this pull request Oct 24, 2022

feat: add new allowLineSeparatedGroups option

099af78

Adapted from eslint/eslint#16138

forivall mentioned this pull request Oct 24, 2022

feat: import features from upstream and shorthand fork forivall/eslint-plugin-sort-keys-plus#5

Merged

eslint-github-bot Bot locked and limited conversation to collaborators Jan 27, 2023

eslint-github-bot Bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jan 27, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: add new `allowLineSeparatedGroups` option to the `sort-keys` rule#16138

feat: add new `allowLineSeparatedGroups` option to the `sort-keys` rule#16138
snitin315 merged 8 commits intomainfrom
feat/allowLineSeparatedGroups-options

snitin315 commented Jul 17, 2022 •

edited

Loading

Uh oh!

netlify Bot commented Jul 17, 2022 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mdjermanovic left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

snitin315 commented Jul 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

Uh oh!

netlify Bot commented Jul 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for docs-eslint ready!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mdjermanovic left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

snitin315 commented Jul 17, 2022 •

edited

Loading

netlify Bot commented Jul 17, 2022 •

edited

Loading