test: cleanup typos by nschonni · Pull Request #15937 · eslint/eslint

nschonni · 2022-05-29T18:03:36Z

Prerequisites checklist

I have read the contributing guidelines.

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

What changes did you make? (Give an overview)

Ran cSpell across the repo and sumbitting the results across the different areas

Is there anything you'd like reviewers to focus on?

netlify · 2022-05-29T18:03:45Z

✅ Deploy Preview for docs-eslint canceled.

Name	Link
🔨 Latest commit	`757cd9d`
🔍 Latest deploy log	https://app.netlify.com/sites/docs-eslint/deploys/62943ec373bfe50009f00078

aladdin-add

LGTM, thanks!

nschonni · 2022-05-30T03:25:06Z

Sorry, just temporarily flipping to draft since I noticed one more minor one while ignoring those 2 files and re-running. Will rebase again and flip to ready

mdjermanovic · 2022-05-30T17:34:52Z

                    /* eslint-disable-next-line no-alert --
                        description on why this exception is seen as appropriate but past a
-                        comfortable reading line length 
+                        comfortable reading line length


This is also okay, it doesn't look like this test was intended to have a trailing space here, so it's better to remove it to avoid confusion.

Yeah, I think that was just an EditorConfig change rather than an intentional one on my part

nschonni · 2022-05-30T17:35:25Z

The one I had to roll out because the test failed was

eslint/tests/lib/rules/no-prototype-builtins.js

Line 44 in 1351a9b

    
           { code: "foo?.['propertyIsEnumerabl']('bar')", parserOptions: { ecmaVersion: 2020 } },

Which has propertyIsEnumerabl instead of propertyIsEnumerable

mdjermanovic

LGTM, thanks!

This also fixes two tests in no-redeclare that did not test cases they were intended to due to typos.

mdjermanovic · 2022-05-30T17:54:47Z

The one I had to roll out because the test failed was

eslint/tests/lib/rules/no-prototype-builtins.js

Line 44 in 1351a9b

{ code: "foo?.['propertyIsEnumerabl']('bar')", parserOptions: { ecmaVersion: 2020 } },

Which has propertyIsEnumerabl instead of propertyIsEnumerable

That's an intentional typo, to check that the rule does not report methods that are not on Object.prototype.

mdjermanovic · 2022-05-30T17:56:44Z

Thanks for contributing!

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [eslint](https://eslint.org) ([source](https://github.com/eslint/eslint)) | devDependencies | minor | [`8.16.0` -> `8.17.0`](https://renovatebot.com/diffs/npm/eslint/8.16.0/8.17.0) | --- ### Release Notes <details> <summary>eslint/eslint</summary> ### [`v8.17.0`](https://github.com/eslint/eslint/releases/tag/v8.17.0) [Compare Source](eslint/eslint@v8.16.0...v8.17.0) #### Features - [`55319e1`](eslint/eslint@55319e1) feat: fix indent bug with semicolon-first style ([#15951](eslint/eslint#15951)) (Milos Djermanovic) - [`f6d7920`](eslint/eslint@f6d7920) feat: add `allowNamedExports` option to no-use-before-define ([#15953](eslint/eslint#15953)) (Milos Djermanovic) #### Bug Fixes - [`54c0953`](eslint/eslint@54c0953) fix: cleanup typos ([#15939](eslint/eslint#15939)) (Nick Schonning) - [`845a7af`](eslint/eslint@845a7af) fix: typo ocatal -> octal ([#15940](eslint/eslint#15940)) (Nick Schonning) #### Documentation - [`b915018`](eslint/eslint@b915018) docs: Update website UI to latest ([#15944](eslint/eslint#15944)) (Nicholas C. Zakas) - [`f0bb609`](eslint/eslint@f0bb609) docs: Update Exponentiation operator MDN link ([#15960](eslint/eslint#15960)) (Pranjal Jain) - [`baa0153`](eslint/eslint@baa0153) docs: Use correct past tense "left" instead of "leaved" ([#15950](eslint/eslint#15950)) (Frederik Braun) - [`1351a9b`](eslint/eslint@1351a9b) docs: Add Resources section to rule pages ([#15901](eslint/eslint#15901)) (Nicholas C. Zakas) - [`68cf0fb`](eslint/eslint@68cf0fb) docs: cleanup typos ([#15936](eslint/eslint#15936)) (Nick Schonning) - [`13b62ae`](eslint/eslint@13b62ae) docs: use-dart-sass instead of node-sass ([#15912](eslint/eslint#15912)) (Deepshika S) - [`c81c5d6`](eslint/eslint@c81c5d6) docs: add social media links ([#15920](eslint/eslint#15920)) (Deepshika S) - [`0d6a50b`](eslint/eslint@0d6a50b) docs: fix openjs link ([#15917](eslint/eslint#15917)) (Amaresh S M) - [`54910f5`](eslint/eslint@54910f5) docs: display version in mobile view ([#15909](eslint/eslint#15909)) (Amaresh S M) #### Chores - [`da694b9`](eslint/eslint@da694b9) chore: avoid theme flashes ([#15927](eslint/eslint#15927)) (Strek) - [`f836743`](eslint/eslint@f836743) chore: Use build hook for docs deploy ([#15945](eslint/eslint#15945)) (Nicholas C. Zakas) - [`ce035e5`](eslint/eslint@ce035e5) test: cleanup typos ([#15937](eslint/eslint#15937)) (Nick Schonning) - [`10249ad`](eslint/eslint@10249ad) chore: use addEventListener instead of addListener ([#15923](eslint/eslint#15923)) (Amaresh S M) - [`5f5c1fb`](eslint/eslint@5f5c1fb) chore: lint eleventy config file ([#15904](eslint/eslint#15904)) (Milos Djermanovic) - [`8513d37`](eslint/eslint@8513d37) chore: update Rule typedefs ([#15915](eslint/eslint#15915)) (Milos Djermanovic) - [`55534f1`](eslint/eslint@55534f1) test: ensure no-restricted-imports works with NodeJS imports ([#15907](eslint/eslint#15907)) (Nick Mazuk) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1395 Reviewed-by: 6543 <6543@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>

eslint-github-bot Bot added chore This change is not user-facing triage An ESLint team member will look at this issue soon labels May 29, 2022

nschonni commented May 29, 2022

View reviewed changes

Comment thread tests/performance/jshint.js

aladdin-add reviewed May 30, 2022

View reviewed changes

Comment thread tests/bench/large.js Outdated

nschonni force-pushed the typos-tests branch from 7e1fb12 to 97fcaa1 Compare May 30, 2022 03:07

aladdin-add approved these changes May 30, 2022

View reviewed changes

nschonni marked this pull request as draft May 30, 2022 03:24

nschonni force-pushed the typos-tests branch from 97fcaa1 to 5c9cade Compare May 30, 2022 03:42

test: cleanup typos

757cd9d

nschonni force-pushed the typos-tests branch from 5c9cade to 757cd9d Compare May 30, 2022 03:49

nschonni commented May 30, 2022

View reviewed changes

Comment thread tests/lib/rules/padding-line-between-statements.js

Comment thread tests/lib/rules/no-redeclare.js

nschonni marked this pull request as ready for review May 30, 2022 04:10

mdjermanovic reviewed May 30, 2022

View reviewed changes

mdjermanovic added accepted There is consensus among the team that this change meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels May 30, 2022

mdjermanovic approved these changes May 30, 2022

View reviewed changes

mdjermanovic merged commit ce035e5 into eslint:main May 30, 2022

nschonni deleted the typos-tests branch May 30, 2022 18:37

sync-by-unito Bot mentioned this pull request Jul 1, 2022

build(deps-dev): bump eslint from 7.32.0 to 8.18.0 numbersprotocol/capture-cam#1769

Closed

eslint-github-bot Bot locked and limited conversation to collaborators Nov 27, 2022

eslint-github-bot Bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Nov 27, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test: cleanup typos#15937

test: cleanup typos#15937
mdjermanovic merged 1 commit intoeslint:mainfrom
nschonni:typos-tests

nschonni commented May 29, 2022 •

edited

Loading

Uh oh!

netlify Bot commented May 29, 2022 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

aladdin-add left a comment

Uh oh!

nschonni commented May 30, 2022

Uh oh!

Uh oh!

Uh oh!

mdjermanovic May 30, 2022

Uh oh!

nschonni May 30, 2022

Uh oh!

nschonni commented May 30, 2022

Uh oh!

mdjermanovic left a comment

Uh oh!

mdjermanovic commented May 30, 2022

Uh oh!

mdjermanovic commented May 30, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

nschonni commented May 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

Uh oh!

netlify Bot commented May 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for docs-eslint canceled.

Uh oh!

Uh oh!

Uh oh!

aladdin-add left a comment

Choose a reason for hiding this comment

Uh oh!

nschonni commented May 30, 2022

Uh oh!

Uh oh!

Uh oh!

mdjermanovic May 30, 2022

Choose a reason for hiding this comment

Uh oh!

nschonni May 30, 2022

Choose a reason for hiding this comment

Uh oh!

nschonni commented May 30, 2022

Uh oh!

mdjermanovic left a comment

Choose a reason for hiding this comment

Uh oh!

mdjermanovic commented May 30, 2022

Uh oh!

mdjermanovic commented May 30, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

nschonni commented May 29, 2022 •

edited

Loading

netlify Bot commented May 29, 2022 •

edited

Loading