Chore: add autofix npm script#12330
Merged
mysticatea merged 1 commit intomasterfrom Sep 29, 2019
Merged
Conversation
platinumazure
approved these changes
Sep 28, 2019
Member
platinumazure
left a comment
There was a problem hiding this comment.
LGTM, thanks!
Probably overthinking this, but: Should we handle differently in case this is called from CI? (It shouldn't be, but...)
Member
Author
|
@platinumazure Mind elaborating on what you mean? Not sure I understand. Thanks! |
Member
|
I was just wondering if we wanted to have an environment variable check in that task, where if the task was called from CI, then it should throw an error. As I type this, I'm thinking not, so go ahead and just ignore what I said. |
This was referenced Oct 22, 2019
This was referenced Nov 9, 2019
This was referenced Mar 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:
What changes did you make? (Give an overview)
This adds a
fixflag to thelinttask inMakefile.jsand adds afixnpm script as a small convenience for contributors.Is there anything you'd like reviewers to focus on?
Nothing in particular!