Skip to content

Fix: no-extra-bind autofix removes comments#12293

Merged
platinumazure merged 1 commit intomasterfrom
noextrabind-comments
Sep 29, 2019
Merged

Fix: no-extra-bind autofix removes comments#12293
platinumazure merged 1 commit intomasterfrom
noextrabind-comments

Conversation

@mdjermanovic
Copy link
Copy Markdown
Member

What is the purpose of this pull request? (put an "X" next to item)

[X] Bug fix

Tell us about your environment

  • ESLint Version: 6.4.0
  • Node Version: 10.16.0
  • npm Version: 6.9.0

What parser (default, Babel-ESLint, etc.) are you using?

default

Please show your full configuration:

Configuration
module.exports = {
  parserOptions: {
    ecmaVersion: 2015,
  }
};

What did you do? Please include the actual source code causing the issue.

Demo link

/* eslint no-extra-bind:error */

var a = function(){}.bind(/* comment */ b /* comment */);

var c = function(){}. // comment
    bind(d);

What did you expect to happen?

2 errors, but no autofix as it would remove comments.

What actually happened? Please include the actual, raw output from ESLint.

/* eslint no-extra-bind:error */

var a = function(){};

var c = function(){};

What changes did you make? (Give an overview)

Report errors but don't fix if that would remove any comments.

Is there anything you'd like reviewers to focus on?

@eslint-deprecated eslint-deprecated Bot added the triage An ESLint team member will look at this issue soon label Sep 19, 2019
Copy link
Copy Markdown
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@kaicataldo kaicataldo added bug ESLint is working incorrectly rule Relates to ESLint's core rules autofix This change is related to ESLint's autofixing capabilities and removed triage An ESLint team member will look at this issue soon labels Sep 19, 2019
@platinumazure platinumazure added the accepted There is consensus among the team that this change meets the criteria for inclusion label Sep 29, 2019
@platinumazure platinumazure merged commit 0e68677 into master Sep 29, 2019
@platinumazure platinumazure deleted the noextrabind-comments branch September 29, 2019 04:10
@eslint-deprecated eslint-deprecated Bot locked and limited conversation to collaborators Mar 29, 2020
@eslint-deprecated eslint-deprecated Bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion autofix This change is related to ESLint's autofixing capabilities bug ESLint is working incorrectly rule Relates to ESLint's core rules

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants