Fix: eqeqeq rule reports incorrect locations#12265
Merged
mysticatea merged 1 commit intomasterfrom Sep 13, 2019
Merged
Conversation
Member
Author
|
Marking as accepted because it's obvious. |
This was referenced Sep 24, 2019
This was referenced Oct 8, 2019
This was referenced Oct 22, 2019
This was referenced Nov 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[X] Bug fix
Tell us about your environment
What parser (default, Babel-ESLint, etc.) are you using?
default
Please show your full configuration:
Configuration
What did you do? Please include the actual source code causing the issue.
Demo link
What did you expect to happen?
1 error with the correct location (column 9)
What actually happened? Please include the actual, raw output from ESLint.
What changes did you make? (Give an overview)
Changed
eqeqeqto find first operator token between, instead of just the first one which could be a paren.Also, changed the rule to report
locinstead ofloc.start. One test incli-enginehad to be modified because of that.Is there anything you'd like reviewers to focus on?
I hope it's ok to change from
loc.starttoloc, it always looks better in VS Code.