Docs: adding finally example#12256
Merged
ilyavolodin merged 1 commit intoeslint:masterfrom Sep 13, 2019
Merged
Conversation
|
|
ilyavolodin
approved these changes
Sep 11, 2019
kaicataldo
approved these changes
Sep 11, 2019
Member
kaicataldo
left a comment
There was a problem hiding this comment.
LGTM! Do you mind updating the commit message to match the PR title?
This was referenced Sep 24, 2019
This was referenced Oct 8, 2019
This was referenced Oct 22, 2019
This was referenced Nov 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Added a finally example under the "Do's".
Considering that there is a try/catch-throw/finally example under the "dont do", shouldn't there be an example of how to do that finally correctly?
Is there anything you'd like reviewers to focus on?