Skip to content

Update: enforceForClassMembers computed-property-spacing (fixes #12049)#12214

Merged
ilyavolodin merged 1 commit intomasterfrom
computedpropertyspacing-class
Sep 14, 2019
Merged

Update: enforceForClassMembers computed-property-spacing (fixes #12049)#12214
ilyavolodin merged 1 commit intomasterfrom
computedpropertyspacing-class

Conversation

@mdjermanovic
Copy link
Copy Markdown
Member

@mdjermanovic mdjermanovic commented Sep 4, 2019

What is the purpose of this pull request? (put an "X" next to item)

[X] Changes an existing rule #12049

What rule do you want to change?

computed-property-spacing

Does this change cause the rule to produce more or fewer warnings?

More if the option is set to true. Default is false.

How will the change be implemented? (New option, new default behavior, etc.)?

New option enforceForClassMembers

Please provide some example code that this change will affect:

/*eslint computed-property-spacing: ["error", "never"]*/

class Foo {
  [a ]() {}
  get [ b ](){}
  set [ b ](val){}
  static [ c](){}
  static get [ d](){}
  static set [d ](val){}
}

What does the rule currently do for this code?

No errors.

What will the rule do after it's changed?

/*eslint computed-property-spacing: ["error", "never", { "enforceForClassMembers": true }]*/

class Foo {
  [a ]() {} // error
  get [ b ](){} // error
  set [ b ](val){} // error
  static [ c](){} // error
  static get [ d](){} // error
  static set [d ](val){} // error
}

Autofix:

/*eslint computed-property-spacing: ["error", "never", { "enforceForClassMembers": true }]*/

class Foo {
  [a]() {}
  get [b](){}
  set [b](val){}
  static [c](){}
  static get [d](){}
  static set [d](val){}
}

What changes did you make? (Give an overview)

New option.

Is there anything you'd like reviewers to focus on?

@eslint-deprecated eslint-deprecated Bot added the triage An ESLint team member will look at this issue soon label Sep 4, 2019
@mdjermanovic mdjermanovic added accepted There is consensus among the team that this change meets the criteria for inclusion enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules and removed triage An ESLint team member will look at this issue soon labels Sep 4, 2019
kaicataldo
kaicataldo approved these changes Sep 4, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

g-plane
g-plane approved these changes Sep 9, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@g-plane g-plane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

mysticatea
mysticatea approved these changes Sep 14, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@mysticatea mysticatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ilyavolodin ilyavolodin merged commit 1ee61b0 into master Sep 14, 2019
@ilyavolodin ilyavolodin deleted the computedpropertyspacing-class branch September 14, 2019 00:52
This was referenced Sep 24, 2019
Merged
Closed
This was referenced Oct 8, 2019
Merged
Closed
This was referenced Oct 22, 2019
Merged
Open
This was referenced Nov 9, 2019
Open
Open
@snyk-bot snyk-bot mentioned this pull request Nov 21, 2019
Merged
@snyk-bot snyk-bot mentioned this pull request Feb 27, 2020
Merged
@a-martynovich a-martynovich mentioned this pull request Mar 10, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Mar 11, 2020
Merged
@eslint-deprecated eslint-deprecated Bot locked and limited conversation to collaborators Mar 13, 2020
@eslint-deprecated eslint-deprecated Bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Mar 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

4 more reviewers

@ilyavolodin ilyavolodin ilyavolodin approved these changes

@mysticatea mysticatea mysticatea approved these changes

@kaicataldo kaicataldo kaicataldo approved these changes

@g-plane g-plane g-plane approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mdjermanovic @ilyavolodin @mysticatea @kaicataldo @g-plane