Docs: corrected class extension example#12176
Merged
aladdin-add merged 1 commit intoeslint:masterfrom Aug 28, 2019
mariuscm:patch-1
Merged
Docs: corrected class extension example#12176aladdin-add merged 1 commit intoeslint:masterfrom mariuscm:patch-1
aladdin-add merged 1 commit intoeslint:masterfrom
mariuscm:patch-1
Conversation
|
|
ilyavolodin
approved these changes
Aug 27, 2019
Contributor
Author
|
corrected commit message and explained changes |
kaicataldo
approved these changes
Aug 28, 2019
Member
kaicataldo
left a comment
There was a problem hiding this comment.
I think this change makes a lot of sense. Thanks for contributing to ESLint!
platinumazure
approved these changes
Aug 28, 2019
Member
platinumazure
left a comment
There was a problem hiding this comment.
LGTM, thanks for contributing to ESLint!
This was referenced Sep 9, 2019
This was referenced Sep 24, 2019
This was referenced Oct 22, 2019
This was referenced Nov 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[X] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
I switched the parent and child class names for the class extension examples in the rules for no-useless-constructor
Is there anything you'd like reviewers to focus on?