Fix: reset to the default color#12174
Merged
btmills merged 1 commit intoeslint:masterfrom Aug 30, 2019
ricardogobbosouza:patch-1
Merged
Fix: reset to the default color#12174btmills merged 1 commit intoeslint:masterfrom ricardogobbosouza:patch-1
btmills merged 1 commit intoeslint:masterfrom
ricardogobbosouza:patch-1
Conversation
|
|
ilyavolodin
approved these changes
Aug 27, 2019
Member
platinumazure
left a comment
There was a problem hiding this comment.
Is there a way to test this change? (E.g., a unit test which changes something about chalk before calling the linter, and then we could check the output to make sure the file name does not have the changes?
I'm also wondering if it would make more sense to just call chalk.reset() by itself earlier in the formatter, so we could have a comment and make clear what's going on?
I'm not strongly opposed to merging as is, but I just want to see if we could make some small improvements here. Thanks!
Contributor
Author
|
@platinumazure I agree, I just changed |
kaicataldo
reviewed
Aug 28, 2019
btmills
approved these changes
Aug 30, 2019
This was referenced Sep 9, 2019
This was referenced Sep 24, 2019
This was referenced Oct 22, 2019
This was referenced Nov 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
When we issue a warning on webpack, every warning is yellow and bold.
With
eslint-loaderand thestylishformatter the first line is different from the others.webpack-contrib/eslint-loader#292
Is there anything you'd like reviewers to focus on?