Skip to content

Chore: Fix wrong error object keys in test files#12162

Merged
kaicataldo merged 1 commit intomasterfrom
test-typos
Aug 26, 2019
Merged

Chore: Fix wrong error object keys in test files#12162
kaicataldo merged 1 commit intomasterfrom
test-typos

Conversation

@mdjermanovic
Copy link
Copy Markdown
Member

@mdjermanovic mdjermanovic commented Aug 25, 2019

What is the purpose of this pull request? (put an "X" next to item)

[X] Other, please explain:

What changes did you make? (Give an overview)

Fixed test cases that had nodeType instead of type and various typos like messgeId in 6 files.

Is there anything you'd like reviewers to focus on?

no-extra-parens tests are fixed in #12142. Other test files are OK in regard to this.

@eslint-deprecated eslint-deprecated Bot added the triage An ESLint team member will look at this issue soon label Aug 25, 2019
@mdjermanovic mdjermanovic added the chore This change is not user-facing label Aug 25, 2019
platinumazure
platinumazure approved these changes Aug 25, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@platinumazure platinumazure added accepted There is consensus among the team that this change meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels Aug 25, 2019
kaicataldo
kaicataldo approved these changes Aug 26, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing this!

@kaicataldo kaicataldo merged commit 31e5428 into master Aug 26, 2019
@kaicataldo
Copy link
Copy Markdown
Member

kaicataldo commented Aug 26, 2019

Thanks for contributing to ESLint!

@platinumazure platinumazure deleted the test-typos branch August 26, 2019 18:13
This was referenced Sep 9, 2019
Merged
Merged
Merged
Merged
This was referenced Sep 24, 2019
Merged
Closed
@snyk-bot snyk-bot mentioned this pull request Oct 13, 2019
Closed
This was referenced Oct 22, 2019
Merged
Open
This was referenced Nov 9, 2019
Open
Open
@snyk-bot snyk-bot mentioned this pull request Nov 21, 2019
Merged
@eslint-deprecated eslint-deprecated Bot locked and limited conversation to collaborators Feb 23, 2020
@eslint-deprecated eslint-deprecated Bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@platinumazure platinumazure platinumazure approved these changes

@kaicataldo kaicataldo kaicataldo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mdjermanovic @kaicataldo @platinumazure