Fix: func-name-matching crash on descriptor-like arguments#12100
Merged
kaicataldo merged 1 commit intoeslint:masterfrom Aug 26, 2019
mdjermanovic:funcnamematching-memberexpr
Merged
Fix: func-name-matching crash on descriptor-like arguments#12100kaicataldo merged 1 commit intoeslint:masterfrom mdjermanovic:funcnamematching-memberexpr
kaicataldo merged 1 commit intoeslint:masterfrom
mdjermanovic:funcnamematching-memberexpr
Conversation
Member
|
I can reproduce it on demo. |
Member
|
Thanks for contributing to ESLint! |
This was referenced Sep 9, 2019
This was referenced Sep 24, 2019
This was referenced Oct 22, 2019
This was referenced Nov 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[X] Bug fix
Tell us about your environment
What parser (default, Babel-ESLint, etc.) are you using?
default
Please show your full configuration:
Configuration
What did you do? Please include the actual source code causing the issue.
What did you expect to happen?
Not to crash.
What actually happened? Please include the actual, raw output from ESLint.
TypeError: Cannot read property 'name' of undefinedWhat changes did you make? (Give an overview)
Fixed the bug.
Is there anything you'd like reviewers to focus on?
There is still a number of places where the rule can crash or produce false positives on a designed example, as the code doesn't check parent types, correct index of the child in parent's arguments, existence and types of other arguments from which it reads etc.
The example which is fixed in this PR can easily occur in a real code, so it might make sense to fix just this at the moment.
For the rest, I believe it would be better to make helpers in
astUtilsas there are at least 3 other rules that also work with descriptors and have a very similar code (and some small bugs as well).