Fix: Check literal type explicitly in dot-notation#12095
Merged
kaicataldo merged 1 commit intoeslint:masterfrom Aug 18, 2019
mdjermanovic:dotnotation-checktype
Merged
Fix: Check literal type explicitly in dot-notation#12095kaicataldo merged 1 commit intoeslint:masterfrom mdjermanovic:dotnotation-checktype
kaicataldo merged 1 commit intoeslint:masterfrom
mdjermanovic:dotnotation-checktype
Conversation
kaicataldo
approved these changes
Aug 18, 2019
Member
kaicataldo
left a comment
There was a problem hiding this comment.
LGTM. Thanks for contributing!
This was referenced Aug 27, 2019
This was referenced Sep 12, 2019
This was referenced Nov 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[X] Bug fix
This is a small fix that prevents
dot-notationfrom convertingbigintand some regex literals tonullin Node 8.Demo link - the error is observable if you open this link in Firefox (which also doesn't support the syntax, like Node 8).
Tell us about your environment
What parser (default, Babel-ESLint, etc.) are you using?
default
Please show your full configuration:
Configuration
What did you do? Please include the actual source code causing the issue.
What did you expect to happen?
No warnings.
What actually happened? Please include the actual, raw output from ESLint.
Warning and the fix:
What changes did you make? (Give an overview)
Fixed
dot-notationto explicitly check only"string","boolean"andnullliterals.Is there anything you'd like reviewers to focus on?
The test in
validfails in Node 8 before the fix. Tests ininvalidare for regression only.