Skip to content

Update: fix no-dupe-keys false negatives on empty string names#12069

Merged
platinumazure merged 1 commit intoeslint:masterfrom
mdjermanovic:nodupekeys-empty
Aug 18, 2019
Merged

Update: fix no-dupe-keys false negatives on empty string names#12069
platinumazure merged 1 commit intoeslint:masterfrom
mdjermanovic:nodupekeys-empty

Conversation

@mdjermanovic
Copy link
Copy Markdown
Member

What is the purpose of this pull request? (put an "X" next to item)

[X] Bug fix

This is a small bug fix, but it can produce more warnings.

Tell us about your environment

  • ESLint Version: 6.1.0
  • Node Version: 10.16.0
  • npm Version: 6.9.0

What parser (default, Babel-ESLint, etc.) are you using?

default

Please show your full configuration:

Configuration
module.exports = {
  parserOptions: {
    ecmaVersion: 2015,
  },
};

What did you do? Please include the actual source code causing the issue.

/*eslint no-dupe-keys: "error"*/

const obj = {
  "": 1,
  "": 2
}

What did you expect to happen?

1 error

What actually happened? Please include the actual, raw output from ESLint.

No errors.

What changes did you make? (Give an overview)

getStaticPropertyName() return value is now explicitly compared to null, because it can be a valid empty string value.

Is there anything you'd like reviewers to focus on?

@eslint-deprecated eslint-deprecated Bot added the triage An ESLint team member will look at this issue soon label Aug 6, 2019
@kaicataldo kaicataldo added bug ESLint is working incorrectly enhancement This change enhances an existing feature of ESLint evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels Aug 6, 2019
Comment thread tests/lib/rules/no-dupe-keys.js
@kaicataldo kaicataldo added accepted There is consensus among the team that this change meets the criteria for inclusion and removed evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Aug 7, 2019
Copy link
Copy Markdown
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for contributing!

Copy link
Copy Markdown
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@platinumazure platinumazure merged commit 2dc23b8 into eslint:master Aug 18, 2019
@platinumazure
Copy link
Copy Markdown
Member

Merged. Thanks for contributing!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly enhancement This change enhances an existing feature of ESLint

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants