Fix: exclude \u000d so new line won't convert to text (fixes #12027)#12031
Merged
mysticatea merged 4 commits intoeslint:masterfrom Sep 29, 2019
Merged
Fix: exclude \u000d so new line won't convert to text (fixes #12027)#12031mysticatea merged 4 commits intoeslint:masterfrom
\u000d so new line won't convert to text (fixes #12027)#12031mysticatea merged 4 commits intoeslint:masterfrom
Conversation
|
|
platinumazure
suggested changes
Jul 27, 2019
Member
platinumazure
left a comment
There was a problem hiding this comment.
Thanks for contributing! Could you please add a unit test for this change?
Contributor
Author
|
@platinumazure added some unit test |
platinumazure
approved these changes
Sep 29, 2019
Member
platinumazure
left a comment
There was a problem hiding this comment.
Thank you for the test! This looks ready to merge from my perspective, but I would like at least one more team member to review.
mysticatea
approved these changes
Sep 29, 2019
This was referenced Oct 22, 2019
This was referenced Nov 9, 2019
This was referenced Mar 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[X] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
#12027
What changes did you make?
I remove an unnecessary
\u000dso that a new line will show properly.Is there anything you'd like reviewers to focus on?