Fix: --rulesdir option didn't work (fixes #11888)#11890
Merged
not-an-aardvark merged 1 commit intomasterfrom Jun 25, 2019
Merged
Fix: --rulesdir option didn't work (fixes #11888)#11890not-an-aardvark merged 1 commit intomasterfrom
not-an-aardvark merged 1 commit intomasterfrom
Conversation
aladdin-add
approved these changes
Jun 24, 2019
Member
|
the build failing somehow, but seems not related to this change. |
Member
Author
|
Some cloud services look bad condition currently (I have seen Netlify timed out on other repos). |
platinumazure
approved these changes
Jun 24, 2019
ilyavolodin
approved these changes
Jun 24, 2019
kaicataldo
approved these changes
Jun 24, 2019
This was referenced Nov 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[X] Bug fix: #11888
What changes did you make? (Give an overview)
This PR fixes a bug that
CLEngineignoredbaseConfigandrulePathsif a config file hasroot:true.Is there anything you'd like reviewers to focus on?
Nothing in particular.