Fix: CLIEngine#getRules() contains plugin rules (fixes #11871)#11872
Merged
mysticatea merged 1 commit intomasterfrom Jun 23, 2019
Merged
Fix: CLIEngine#getRules() contains plugin rules (fixes #11871)#11872mysticatea merged 1 commit intomasterfrom
mysticatea merged 1 commit intomasterfrom
Conversation
aladdin-add
approved these changes
Jun 22, 2019
platinumazure
approved these changes
Jun 22, 2019
Member
platinumazure
left a comment
There was a problem hiding this comment.
LGTM, thanks!
In your view, should this be a patch release candidate?
Member
Author
|
Yes, I think so. |
ilyavolodin
approved these changes
Jun 22, 2019
kaicataldo
approved these changes
Jun 22, 2019
This was referenced Nov 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[X] Bug fix: #11871
What changes did you make? (Give an overview)
This PR fixes
CLIEngineas the following code contains plugin rules.Previously,
CLIEngine#getRules()contains core rules and the plugin rules that the lastCLIEngine#executeOn*()methods call used.This PR changes only the behavior that is before
CLIEngine#executeOn*()methods called.Is there anything you'd like reviewers to focus on?
Nothing in particular.