Add build assertion against {{outlet named}}#19691
Merged
mixonic merged 1 commit intoemberjs:masterfrom Aug 17, 2021
Merged
Conversation
5178764 to
c57552d
Compare
Named outlets are effectively removed in Ember 4.0, as the render hook and `renderTemplate` method which are used to configure them have been removed. Add an assertion to catch anyone trying to use this API going forward.
c57552d to
392981c
Compare
mixonic
commented
Aug 1, 2021
| import { moduleFor, AbstractTestCase } from 'internal-test-helpers'; | ||
|
|
||
| moduleFor( | ||
| 'ember-template-compiler: assert-against-named-outlets', |
Member
Author
There was a problem hiding this comment.
I'm not sure where to look in CI output to assert this was run on CI.
Member
There was a problem hiding this comment.
kategengler
approved these changes
Aug 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Named outlets are effectively removed in Ember 4.0, as the render hook and
renderTemplatemethod which are used to configure them have been removed. Add an assertion to catch anyone trying to use this API going forward.See also: #19659 (comment)