Remove renderTemplate, disconnectOutlet, render#19659
Merged
rwjblue merged 1 commit intoemberjs:masterfrom Jul 21, 2021
Merged
Conversation
96f0fd3 to
7f1513c
Compare
Removing these features also effectively removes support for named outlets.
7f1513c to
8547049
Compare
rwjblue
approved these changes
Jul 21, 2021
Member
Author
|
The comment here around edit: Implemented at #19691 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing these features also effectively removes support for named outlets, however I did not update the docs or code to prevent a name from being passed to
{{outlet 'foo'}}as it was not explicitly deprecated.Per #19617