[EuiComboBox] Fix Entering to select items within groups#7658
Merged
cee-chen merged 4 commits intoelastic:mainfrom Apr 8, 2024
Merged
[EuiComboBox] Fix Entering to select items within groups#7658cee-chen merged 4 commits intoelastic:mainfrom
Entering to select items within groups#7658cee-chen merged 4 commits intoelastic:mainfrom
Conversation
…havior + add unit tests for both cases
- remove a ton of now-unnecessary lowercase normalization checks that EuiComboBox handles automatically - had a `custom` undefined error on every new custom creation that was due to too many `setAllOptions` calls - use a callback and an `=` destructure fallback to fix all those things
|
Preview staging links for this PR:
|
Collaborator
💚 Build Succeeded
|
mbondyra
reviewed
Apr 8, 2024
Contributor
There was a problem hiding this comment.
@cee-chen I noticed one more issue, but maybe it's by design? When you have more than one options but one is exact, it's not gonna get chosen. I noticed it by checking this case:
I am ok if that's how it is supposed to work, and sorry for commenting in only vaguely related PR 😬
Contributor
Author
|
@mbondyra You're totally good!! It is by design, yes, I assume to reduce ambiguity. Users can still access the first option via keyboard only by using the down arrow key to highlight it and then pressing Enter. |
cee-chen
added a commit
to elastic/kibana
that referenced
this pull request
Apr 9, 2024
`v93.5.2` ⏩ `v93.6.0` --- ## [`v93.6.0`](https://github.com/elastic/eui/releases/v93.6.0) - Updated `EuiBreadcrumb` styles to improve visual distinction of clickable breadcrumbs ([#7615](elastic/eui#7615)) **Deprecations** - Deprecated `color` prop on `EuiBreadcrumb` ([#7615](elastic/eui#7615)) **Bug fixes** - Fixed `EuiComboBox` to correctly select full matches within groups via the `Enter` key ([#7658](elastic/eui#7658)) **Accessibility** - Updated `EuiHeaderBreadcrumb` styles to ensure min. required color contrast ([#7643](elastic/eui#7643)) - `EuiSuperSelect` now correctly reads out parent `EuiFormRow` labels to screen readers ([#7650](elastic/eui#7650)) - `EuiSuperSelect` now more closely mimics native `<select>` behavior in its keyboard behavior and navigation ([#7650](elastic/eui#7650)) - `EuiSuperSelect` no longer strands keyboard focus on close ([#7650](elastic/eui#7650)) - `EuiSuperSelect` now correctly allows keyboard navigating past disabled options in the middle of the options list ([#7650](elastic/eui#7650))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
closes #7653
See the below QA steps
QA
redorpop)EnteronCreateOptioncallback.General checklist
and screenreader modes- [ ] Checked in both light and dark modes- [ ] Checked in mobile- [ ] Checked in Chrome, Safari, Edge, and Firefoxand cypress tests- [ ] If applicable, added the breaking change issue label (and filled out the breaking change checklist)