[EuiBreadcrumb] Update color to ensure min. color contrast#7643
Merged
mgadewoll merged 6 commits intoelastic:mainfrom Apr 5, 2024
Merged
[EuiBreadcrumb] Update color to ensure min. color contrast#7643mgadewoll merged 6 commits intoelastic:mainfrom
mgadewoll merged 6 commits intoelastic:mainfrom
Conversation
cee-chen
reviewed
Apr 2, 2024
MichaelMarcialis
approved these changes
Apr 2, 2024
cee-chen
reviewed
Apr 2, 2024
cee-chen
reviewed
Apr 2, 2024
- updates styles to scope design changes to page breadcrumbs only + re-adds font-weight for application breadcrumbs
2de642f to
353ecf5
Compare
cee-chen
approved these changes
Apr 5, 2024
Contributor
cee-chen
left a comment
There was a problem hiding this comment.
🥳 Awesome work on this Lene!!
|
Preview staging links for this PR:
|
Collaborator
💚 Build Succeeded
History
|
cee-chen
added a commit
to elastic/kibana
that referenced
this pull request
Apr 9, 2024
`v93.5.2` ⏩ `v93.6.0` --- ## [`v93.6.0`](https://github.com/elastic/eui/releases/v93.6.0) - Updated `EuiBreadcrumb` styles to improve visual distinction of clickable breadcrumbs ([#7615](elastic/eui#7615)) **Deprecations** - Deprecated `color` prop on `EuiBreadcrumb` ([#7615](elastic/eui#7615)) **Bug fixes** - Fixed `EuiComboBox` to correctly select full matches within groups via the `Enter` key ([#7658](elastic/eui#7658)) **Accessibility** - Updated `EuiHeaderBreadcrumb` styles to ensure min. required color contrast ([#7643](elastic/eui#7643)) - `EuiSuperSelect` now correctly reads out parent `EuiFormRow` labels to screen readers ([#7650](elastic/eui#7650)) - `EuiSuperSelect` now more closely mimics native `<select>` behavior in its keyboard behavior and navigation ([#7650](elastic/eui#7650)) - `EuiSuperSelect` no longer strands keyboard focus on close ([#7650](elastic/eui#7650)) - `EuiSuperSelect` now correctly allows keyboard navigating past disabled options in the middle of the options list ([#7650](elastic/eui#7650))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
closes #7514
This PR updates the styles of
EuiBreadcrumbwithtype="application"to increase color contrast to ensure the required contrast minimum level (AA) of4.5Changes
primarybutton colors for interactive breadcrumbstransparentizewithtintOrShadeon non-interactive breadcrumb styles and adjusts values to result in contrast above4.5light mode
light_mode.mov
dark mode
dark_mode.mov
QA
EuiBreadcrumbs(storybook) andEuiHeaderBreadcrumbs(storybook) and verify the min. required color contrasttypetoapplication(if not preset)General checklist
- [ ] Checked in mobile- [ ] Checked for accessibility including keyboard-only and screenreader modescypress tests