[EuiPopover] Remove hasShadow and hasBorder from panelProps type#6836
Merged
cee-chen merged 3 commits intoelastic:mainfrom Jun 8, 2023
Merged
[EuiPopover] Remove hasShadow and hasBorder from panelProps type#6836cee-chen merged 3 commits intoelastic:mainfrom
hasShadow and hasBorder from panelProps type#6836cee-chen merged 3 commits intoelastic:mainfrom
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6836/ |
hasShadow and hasBorder from panelPropshasShadow and hasBorder from panelProps type
1d43d26 to
8185481
Compare
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6836/ |
breehall
added a commit
to elastic/kibana
that referenced
this pull request
Jun 14, 2023
eui@81.3.0 ⏩ eui@82.1.0 ## [`82.1.0`](https://github.com/elastic/eui/tree/v82.1.0) - Added ability for `EuiMarkdownEditor` plugins to disable toolbar buttons ([#6840](elastic/eui#6840)) ## [`82.0.0`](https://github.com/elastic/eui/tree/v82.0.0) **Bug fixes** - Fixed `EuiPopover`'s types to omit `panelProps.hasBorder` and `panelProps.hasShadow` - these props are not customizable on popovers for visual consistency ([#6836](elastic/eui#6836)) **Breaking changes** - `EuiRange` & `EuiDualRange` no longer have a hard limit of 20 displayed ticks. The component now instead detects the width available, and throws an error if each tick has less than 5 pixels of width. We recommend testing your tick usage at smaller screens to ensure they always display legibly to users. ([#6829](elastic/eui#6829))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
closes #6832
The
hasShadowandhasBorderprops cannot be customized on EuiPopover's panel display as a general visual and accessibility consistency pattern. Their props should not be listed as available in our props table or via TS.This PR does not change any actual end-user or consumer behavior, it simply fixes our typing and props docs.
QA
Propstab on the first exampleEuiPopoverPanelPropsand confirmhasShadowandhasBorderare not documentedGeneral checklist
(using@defaultif default values are missing) and playground toggles