Remove sass-extract dependency#6443
Merged
cee-chen merged 11 commits intoelastic:mainfrom Nov 30, 2022
Merged
Conversation
5 tasks
- it should only compile scss now
- now that `.json` files are no longer being dynamically generated, there should be no need to commit changes for them
…NO USAGE in Kibana
2a3c4f2 to
4926954
Compare
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6443/ |
Contributor
chandlerprall
left a comment
There was a problem hiding this comment.
One small nit, everything else LGTM.
Opinion: I like including the initial value cleanup here. Only reason I'd avoid is if we wanted to avoid a breaking change at the moment, but IMO it's a better choice to do now.
Contributor
Author
Since our current next set of changes for the next Kibana upgrade is fairly light, I'd vote for doing it now. I don't think we'll get a better opportunity! |
Contributor
|
One more spot to remove the package name: the compile-scss script in package.json:L23. |
Contributor
Author
The console/return needed to be removed as well: dffa733 |
- caught after testing in Kibana + running through a diff checker
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6443/ |
Contributor
Author
|
Re-built, re-tested this against local Kibana, and re-ran Kibana |
jbudz
pushed a commit
to elastic/kibana
that referenced
this pull request
Dec 19, 2022
eui@70.4.0 ⏩ eui@71.0.0 --- ## [`71.0.0`](https://github.com/elastic/eui/tree/v71.0.0) - Implemented new `EuiRange` and `EuiDualRange` designs where the `levels` are now on top of the tracks ([#6092](elastic/eui#6092)) - Added `discuss` and `dotInCircle` glyphs to `EuiIcon` ([#6434](elastic/eui#6434)) - Added `article` glyph to `EuiIcon` ([#6437](elastic/eui#6437)) - Changed the `EuiProvider` usage warnings to not rely on development mode. ([#6451](elastic/eui#6451)) **Breaking changes** - `EuiDualRange` now explicitly requires both `min` and `max` via props types, to match `EuiRange` ([#6092](elastic/eui#6092)) - `EuiRange` and `EuiDualRange`'s `compressed` size no longer impacts track or level sizes, but continues to compress tick and input sizes. ([#6092](elastic/eui#6092)) - Removed all variables for the following components from EUI's theme JSON files: ([#6443](elastic/eui#6443)) - `euiCollapsibleNav*` - `euiColorPicker*` - `euiContextMenu*` - `euiControlBar*` - `euiDataGrid* `(except for z-indices and cell padding sizes) - `euiDatePicker*` - `euiSuperDatePicker*` - `euiDragAndDrop*` - `euiEuiEmptyPrompt*` - `euiFilePicker*` - `euiRange*` - `euiHeaderLinks*` - `euiKeyPad*` - `euiMarkdownEditor*` - `euiResizable*` - `euiSelectable*` - `euiSideNav*` - `euiStep*` - `euiSuggest*` - `euiTable*` (except for color variables) - `euiTooltip*` - `euiButtonFontWeight`, `euiButtonDefaultTransparency`, and `euiButtonMinWidth` - If you were importing any of the above removed JSON variables, we strongly recommend using generic color or sizing variables from `useEuiTheme()` instead. ([#6443](elastic/eui#6443)) **CSS-in-JS conversions** - Converted `EuiRange` and `EuiDualRange` to Emotion; Removed `$euiRangeThumbRadius` ([#6092](elastic/eui#6092)) - Added a new `logicalStyles` utility that automatically converts all non-logical properties in a `style` object to their corresponding logical properties ([#6426](elastic/eui#6426)) - Added a new `logicalShorthandCSS` utility that automatically converts `margin`, `padding`, and other 4-sided shorthands to their corresponding logical properties ([#6429](elastic/eui#6429)) - Added a new `logicalBorderRadiusCSS` utility that automatically converts `border-radius` to corresponding logical properties ([#6429](elastic/eui#6429)) Co-authored-by: Constance Chen <constance.chen@elastic.co> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is part of a higher-level goal of removing our
node-sassdependency (see #6442).I took the approach of simply removing all logic extracting variables from our Sass files totally. Since EUI's Sass is essentially in deprecation mode and we are no longer adding new Sass variables, there should be no downside to statically committing our
.jsonand.json.d.tsfiles to source control.This also allows us more time to figure out how to transition Kibana's various usages of their exported theme vars to the new EuiTheme vars more smoothly. We will, however, need to figure out how to continue exporting
$eui*Sass variables to a.scssfile for Sass consumers to continue to use.I strongly recommend code-reviewing by commit.
Since removing vars from the
.jsonfiles is no longer an automated process that happens on compile/build/release, I went ahead and looked for component specific variables not being used in Kibana and ripped them out from the existing JSON file: 4926954I left generic high-level variables alone for now, and I also left "groups" of variables actively being used in Kibana alone (of which there were a very annoying amount - we're going to have our work cut out for us :)
I'm 50/50 on doing all this in this PR vs just doing it as we convert components to Emotion, but I figure now isn't a bad time because it helps highlights remaining usage to resolve. That being said, if we feel strongly, I can absolutely take this commit out of the PR for now.
QA
eui/distfolder (archive would be for comparison)yarn compile-scssGeneral checklist
- [ ] Checked for accessibility including keyboard-only and screenreader modes- [ ] Updated the Figma library counterpart- [ ] Props have proper autodocs and playground toggles- [ ] Added documentation- [ ] Checked Code Sandbox works for any docs examples- [ ] Added or updated jest and cypress tests