[EuiSelectable] Prevent onFocus from negating selection#5117
Merged
thompsongl merged 3 commits intoelastic:masterfrom Sep 1, 2021
Merged
[EuiSelectable] Prevent onFocus from negating selection#5117thompsongl merged 3 commits intoelastic:masterfrom
onFocus from negating selection#5117thompsongl merged 3 commits intoelastic:masterfrom
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5117/ |
chandlerprall
approved these changes
Sep 1, 2021
Contributor
chandlerprall
left a comment
There was a problem hiding this comment.
Change LGTM, pulled & tried my hardest to break this locally.
We've dealt with differentiating the tab-vs-click focus response a few times, perhaps we should look at a more formal way to detect & handle them.
Contributor
Author
That's a good point. I'm going to merge this as-is, but keep this in mind as I continue my spike on EuiSelectable things. |
Contributor
|
😬 I think you forgot to revert the |
Contributor
Author
|
Sure did 🤦 |
This was referenced Sep 1, 2021
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4147, in which a click event on an unfocused EuiSelectable would prevent the intended option click and instead scroll to the currently selected option (i.e., two clicks were required because the first was captured by
onFocus).The fix is to look for click events on the element that watches for
onFocusand prevent the handler from running. The subsequent events triggered by the option selection will correctly place focus inside the list and allow for keyboard navigation. Keyboard navigation is otherwise unaffected.Repro:
Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Props have proper autodocs and playground toggles- [ ] Added documentation- [ ] Checked Code Sandbox works for the any docs examples- [ ] Added or updated jest tests2fbc966