Fix screenreader text in DG sort dropdown#5084
Merged
snide merged 4 commits intoelastic:masterfrom Aug 25, 2021
Merged
Conversation
4 tasks
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5084/ |
cee-chen
approved these changes
Aug 25, 2021
Contributor
cee-chen
left a comment
There was a problem hiding this comment.
Confirmed this is working great - thanks Dave!
Co-authored-by: Constance <constancecchen@users.noreply.github.com>
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5084/ |
1 similar comment
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5084/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5081
EuiScreenReaderuses clones to apply classnames. If wrapped around ani18nblock along, it can not pass the CSS class to the inner item.Checklist
[x] Check against all themes for compatibility in both light and dark modes[ ] Checked in mobile[x] Props have proper autodocs and **[playground toggles](https://github.com/elastic/eui/blob/master/wiki/documentation-guidelines.md#adding-playground-toggles)**[ ] Checked Code Sandbox works for the any docs examples[ ] Added or updated jest tests[ ] Checked for breaking changes and labeled appropriately