[EuiTooltip] Revert "Remove tooltip focus on mousemove (#3335)" and force visibility while element is focused#5066
Merged
cchaos merged 13 commits intoelastic:masterfrom Aug 24, 2021
Conversation
added 2 commits
August 19, 2021 18:44
This reverts commit fd3dd84. # Conflicts: # CHANGELOG.md # src/components/tool_tip/tool_tip.tsx
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5066/ |
1 similar comment
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5066/ |
Contributor
Author
|
FYI: I've decided to update the docs too, working on that now. Reviews can hold until I've pushed the updates. |
7 tasks
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5066/ |
Contributor
Author
|
Ok, this is reviewable again 😸 |
chandlerprall
approved these changes
Aug 24, 2021
Contributor
chandlerprall
left a comment
There was a problem hiding this comment.
Changes LGTM! Tested in the deployed docs & verified some changes locally
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5066/ |
2 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5013 by reverting #3335 and applied the
onFocusandonBlurevent handlers to the cloned child which basically means that while the wrapped item hasfocusthe tooltip will never close.Before
Screen.Recording.2021-08-23.at.12.03.17.PM.mp4
Just reverting
Screen.Recording.2021-08-23.at.12.07.00.PM.mp4
Forces visibility while in focus
Screen.Recording.2021-08-23.at.12.19.20.PM.mp4
What would be even better
Is if we could also keep the tooltip shown when a user tries to interact with the contents. I know we've mostly said that interactive content should not be placed within tooltips, but use popovers instead. I still think this is correct, but I do think it would be helpful for when users might want to copy text.
Example of it not working right now:
Screen.Recording.2021-08-23.at.12.30.56.PM.mp4
Thought process:
Originally posted by @cchaos on #5013 (comment)
Checklist
- [ ] Props have proper autodocs and playground toggles- [ ] Checked Code Sandbox works for the any docs examples- [ ] Added or updated jest tests